Bug 13068: [QA Follow-up] Remove the Talking-Tech-itiva file from atomicupdate

The file can be removed. The code is included in the db revisions
3.09.00.014 and 3.15.00.040.
Also I adjusted the text of TalkingTech.README and removed the reference to
the atomicupdate file.

NOTE: I open a new report for adding TalkingTechItivaPhoneNotification to
sysprefs.sql. Probably, the text inserted in the db revisions should have
been inserted into the sample notices sql text too. These corrections are
outside the scope of this report.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

diff --git a/installer/data/mysql/atomicupdate/Bug-4246-Talking-Tech-itiva-phone-notifications.pl b/installer/data/mysql/atomicupdate/Bug-4246-Talking-Tech-itiva-phone-notifications.pl
deleted file mode 100644 (file)
index 5355554..0000000
--- a/installer/data/mysql/atomicupdate/Bug-4246-Talking-Tech-itiva-phone-notifications.pl
+++ /dev/null
@@ -1,27 +0,0 @@
-#! /usr/bin/perl
-use strict;
-use warnings;
-use C4::Context;
-my $dbh = C4::Context->dbh;
-
-# add phone message transport type
-$dbh->do("INSERT INTO message_transport_types (message_transport_type) VALUES ('phone')");
-
-# adds HOLD and PREDUE letters (as placeholders)
-$dbh->do("INSERT INTO letter (module, code, name, title, content, message_transport_type) VALUES
-          ('reserves', 'HOLD', 'Item Available for Pick-up (phone notice)', 'Item Available for Pick-up (phone notice)', 'Your item is available for pickup', 'phone'),
-          ('circulation', 'PREDUE', 'Advance Notice of Item Due (phone notice)', 'Advance Notice of Item Due (phone notice)', 'Your item is due soon', 'phone'),
-          ('circulation', 'OVERDUE', 'Overdue Notice (phone notice)', 'Overdue Notice (phone notice)', 'Your item is overdue', 'phone')
-          ");
-
-# add phone notifications to patron message preferences options
-$dbh->do("INSERT INTO message_transports
-         (message_attribute_id, message_transport_type, is_digest, letter_module, letter_code) VALUES
-         (4, 'phone', 0, 'reserves', 'HOLD'),
-         (2, 'phone', 0, 'circulation', 'PREDUE')
-         ");
-
-# add TalkingTechItivaPhoneNotification syspref
-$dbh->do("INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('TalkingTechItivaPhoneNotification',0,'If ON, enables Talking Tech I-tiva phone notifications',NULL,'YesNo');");
-
-print "Upgrade done (Support for Talking Tech i-tiva phone notification system)\n";

diff --git a/installer/data/mysql/atomicupdate/README b/installer/data/mysql/atomicupdate/README
new file mode 100644 (file)
index 0000000..b17dc9a
--- /dev/null
+++ b/installer/data/mysql/atomicupdate/README
@@ -0,0 +1,2 @@
+Please put your database revision files in this folder.
+The Release Manager will remove them here when pushing your patches.

diff --git a/misc/cronjobs/thirdparty/TalkingTech.README b/misc/cronjobs/thirdparty/TalkingTech.README
index 7120d85..f1e66a8 100644 (file)
--- a/misc/cronjobs/thirdparty/TalkingTech.README
+++ b/misc/cronjobs/thirdparty/TalkingTech.README
@@ -1,13 +1,9 @@
 Installation and Setup instructions for Talking Tech I-tiva phone notification
 =============================
 
-Be sure you've run installer/data/mysql/atomicupdate/Bug-4246-Talking-Tech-itiva-phone-notifications.pl
-to install the required data pack (new syspref, notice placeholders and messaging transport preferences)
+Be sure you enabled the TalkingTechItivaPhoneNotification syspref and you created notice text for the Phone message transport type under the HOLD, PREDUE and OVERDUE notices. (See Tools > Notices & Slips.)
 
-To use, TalkingTechItivaPhoneNotification syspref must be turned on.
-
-If you wish to process PREOVERDUE or RESERVES messages, you'll need the EnhancedMessagingPreferences
-system preference turned on, and patrons to have filled in a perference for receiving these notices by phone.
+If you wish to process PREDUE or HOLD messages, you'll need the EnhancedMessagingPreferences system preference turned on, and patrons to have filled in a preference for receiving these notices by phone.
 
 For OVERDUE messages, overdue notice triggers must be configured under Koha -> Tools -> Overdue Notice Triggers.
 Either branch-specific triggers or the default level triggers may be used (script will select whichever is appropriate).