Bug 32030: Remove warnings from tests

Use of uninitialized value $provider in string eq

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

diff --git a/Koha/REST/V1/ERM/EHoldings/Packages.pm b/Koha/REST/V1/ERM/EHoldings/Packages.pm
index 9552e0c..1dc3e74 100644 (file)
--- a/Koha/REST/V1/ERM/EHoldings/Packages.pm
+++ b/Koha/REST/V1/ERM/EHoldings/Packages.pm
@@ -71,7 +71,7 @@ sub add {
     my $c = shift->openapi->valid_input or return;
 
     my $provider = $c->validation->param('provider');
-    if ( $provider eq 'ebsco' ) {
+    if ( $provider && $provider eq 'ebsco' ) {
         die "invalid action";
     } else {
         return Koha::REST::V1::ERM::EHoldings::Packages::Local::add($c);
@@ -88,7 +88,7 @@ sub update {
     my $c = shift->openapi->valid_input or return;
 
     my $provider = $c->validation->param('provider');
-    if ( $provider eq 'ebsco' ) {
+    if ( $provider && $provider eq 'ebsco' ) {
         die "invalid action";
     } else {
         return Koha::REST::V1::ERM::EHoldings::Packages::Local::update($c);
@@ -103,7 +103,7 @@ sub delete {
     my $c = shift->openapi->valid_input or return;
 
     my $provider = $c->validation->param('provider');
-    if ( $provider eq 'ebsco' ) {
+    if ( $provider && $provider eq 'ebsco' ) {
         die "invalid action";
     } else {
         return Koha::REST::V1::ERM::EHoldings::Packages::Local::delete($c);

diff --git a/Koha/REST/V1/ERM/EHoldings/Titles.pm b/Koha/REST/V1/ERM/EHoldings/Titles.pm
index 8eecf3f..97a3f0b 100644 (file)
--- a/Koha/REST/V1/ERM/EHoldings/Titles.pm
+++ b/Koha/REST/V1/ERM/EHoldings/Titles.pm
@@ -71,7 +71,7 @@ sub add{
     my $c = shift->openapi->valid_input or return;
 
     my $provider = $c->validation->param('provider');
-    if ( $provider eq 'ebsco' ) {
+    if ( $provider && $provider eq 'ebsco' ) {
         die "invalid action";
     } else {
         return Koha::REST::V1::ERM::EHoldings::Titles::Local::add($c);
@@ -89,7 +89,7 @@ sub update {
     my $c = shift->openapi->valid_input or return;
 
     my $provider = $c->validation->param('provider');
-    if ( $provider eq 'ebsco' ) {
+    if ( $provider && $provider eq 'ebsco' ) {
         die "invalid action";
     } else {
         return Koha::REST::V1::ERM::EHoldings::Titles::Local::update($c);
@@ -104,7 +104,7 @@ sub delete {
     my $c = shift->openapi->valid_input or return;
 
     my $provider = $c->validation->param('provider');
-    if ( $provider eq 'ebsco' ) {
+    if ( $provider && $provider eq 'ebsco' ) {
         die "invalid action";
     } else {
         return Koha::REST::V1::ERM::EHoldings::Titles::Local::delete($c);