Bug 23207: (QA follow-up) Add COMMENT to new column

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
JD amended patch: FIX syntax error.(swap COMMENT and AFTER)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/installer/data/mysql/atomicupdate/bug_23027.perl b/installer/data/mysql/atomicupdate/bug_23027.perl
index 5e7a578..4494ae6 100644 (file)
--- a/installer/data/mysql/atomicupdate/bug_23027.perl
+++ b/installer/data/mysql/atomicupdate/bug_23027.perl
@@ -1,9 +1,10 @@
 $DBversion = 'XXX'; # will be replaced by the RM
 if( CheckVersion( $DBversion ) ) {
     if( !column_exists( 'itemtypes', 'automatic_checkin' ) ) {
-       $dbh->do(q{
-           ALTER TABLE itemtypes ADD COLUMN `automatic_checkin` tinyint(1) NOT NULL DEFAULT 0 AFTER `searchcategory` -- 1 if automatic checkin is enabled for items of this type
-       });
+        $dbh->do(q{
+            ALTER TABLE itemtypes
+                ADD COLUMN `automatic_checkin` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'If automatic checkin is enabled for items of this type' AFTER `searchcategory`
+        });
     }
 
     # Always end with this (adjust the bug info)

diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
index 06e16e0..18fe28c 100644 (file)
--- a/installer/data/mysql/kohastructure.sql
+++ b/installer/data/mysql/kohastructure.sql
@@ -3133,7 +3133,7 @@ CREATE TABLE `itemtypes` (
   `sip_media_type` varchar(3) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'SIP2 protocol media type for this itemtype',
   `hideinopac` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'Hide the item type from the search options in OPAC',
   `searchcategory` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'Group this item type with others with the same value on OPAC search options',
-  `automatic_checkin` tinyint(1) NOT NULL DEFAULT 0, -- 1 if automatic checkin is enabled for items of this type
+  `automatic_checkin` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'If automatic checkin is enabled for items of this type',
   PRIMARY KEY (`itemtype`),
   UNIQUE KEY `itemtype` (`itemtype`),
   KEY `itemtypes_ibfk_1` (`parent_type`),