Bug 24798: smart-rules.tt has erroneous comments
authorOwen Leonard <oleonard@myacpl.org>
Wed, 4 Mar 2020 18:29:24 +0000 (18:29 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 6 Mar 2020 09:54:32 +0000 (09:54 +0000)
This patch corrects a couple of invalid Template Toolkit comments in the
Circulation and Fines rules template.

To test, apply the patch and log into the staff client as an
administrator.

On the Circulation and Fines Rules page "View source" and look for
instances of the text "[#% Default branch %#]" There should be none.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] There is a theoretical difference between [% # and [%#. The latter
marks the whole directive as a comment and not just until EOL.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt

index e0f50bf..5ae3bb9 100644 (file)
                 <tr>
                     <td>
                         <select name="refund">
-                          [#% Default branch %#]
+                          [%# Default branch %]
                           [% IF ( current_branch == '*' ) %]
                             [% IF ( defaultRefundRule ) %]
                             <option value="1" selected="selected">
                                 No
                             </option>
                           [% ELSE %]
-                          [#% Branch-specific %#]
+                          [%# Branch-specific %]
                             [% IF ( not refundLostItemFeeRule ) %]
                                 <option value="*" selected="selected">
                             [% ELSE %]