Bug 24159: Use days_mode circ rule to calculate the dropbox date
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 12 Mar 2020 07:46:59 +0000 (08:46 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 25 Jun 2020 08:51:59 +0000 (10:51 +0200)
Calculate the drop box date depending on the circ rule. Note that only
the branchcode is taken into account here. Is that correct?

Test plan:
Use the drop box date feature and confirm that it takes into account the
calendar, depending on the circ rule.

Signed-off-by: Simon Perry <simon.perry@itcarlow.ie>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Checkouts.pm

index 84d4253..1f33cb1 100644 (file)
@@ -48,8 +48,15 @@ sub calculate_dropbox_date {
     my $userenv    = C4::Context->userenv;
     my $branchcode = $userenv->{branch} // q{};
 
-    my $calendar = Koha::Calendar->new( branchcode => $branchcode );
-    my $today        = dt_from_string();
+    my $useDaysMode_value = Koha::CirculationRules->get_useDaysMode_effective_value(
+        {
+            categorycode => undef,
+            itemtype     => undef,
+            branchcode   => $branchcode,
+        }
+    );
+    my $calendar     = Koha::Calendar->new( branchcode => $branchcode, days_mode => $useDaysMode_value );
+    my $today        = dt_from_string;
     my $dropbox_date = $calendar->addDate( $today, -1 );
 
     return $dropbox_date;