There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins.
But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array.
Actually this tabloop variable is never used from cataloguing plugins, we should remove it.
Test plan:
Read the code and confirm the above.
You can also test a couple of plugins and confirm that they are still
working.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
name => $subfield->{value_builder},
item_style => 1,
});
- my $pars = { dbh => $dbh, record => undef, tagslib =>$tagslib, id => $subfield_data{id}, tabloop => undef };
+ my $pars = { dbh => $dbh, record => undef, tagslib =>$tagslib, id => $subfield_data{id} };
$plugin->build( $pars );
if ( $itemrecord and my $field = $itemrecord->field($tag) ) {
$defaultvalue = $field->subfield($subfield->{subfield}) || q{};
Generate html and javascript by calling the builder sub of the plugin.
Params is a hashref supporting keys: id (=html id for the input field),
- record (MARC record or undef), dbh (database handle), tagslib, tabloop.
+ record (MARC record or undef), dbh (database handle), tagslib.
Note that some of these parameters are not used in most (if not all)
plugins and may be obsoleted in the future (kept for now to provide
backward compatibility).
my @params = $self->{oldschool}//0 ?
( $params->{dbh}, $params->{record}, $params->{tagslib},
- $params->{id}, $params->{tabloop} ):
+ $params->{id} ):
( $params );
my @rv = &$sub( @params );
return $self->_error( 'Builder sub failed: ' . $@ ) if $@;
=cut
sub create_input {
- my ( $tag, $subfield, $value, $index_tag, $tabloop, $rec, $authorised_values_sth,$cgi ) = @_;
-
+ my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi ) = @_;
+
my $index_subfield = CreateKey(); # create a specifique key for each subfield
# determine maximum length; 9999 bytes per ISO 2709 except for leader and MARC21 008
name => $tagslib->{$tag}->{$subfield}->{'value_builder'},
});
my $pars= { dbh => $dbh, record => $rec, tagslib =>$tagslib,
- id => $subfield_data{id}, tabloop => $tabloop };
+ id => $subfield_data{id} };
$plugin->build( $pars );
if( !$plugin->errstr ) {
$subfield_data{marc_value} = {
push(
@subfields_data,
&create_input(
- $tag, $subfield, $value, $index_tag, $tabloop, $record,
+ $tag, $subfield, $value, $index_tag, $record,
$authorised_values_sth,$input
)
);
push(
@subfields_data,
&create_input(
- $tag, $subfield, $value, $index_tag, $tabloop,
+ $tag, $subfield, $value, $index_tag,
$record, $authorised_values_sth,$input
)
);
push(
@subfields_data,
&create_input(
- $tag, $subfield, '', $index_tag, $tabloop, $record,
+ $tag, $subfield, '', $index_tag, $record,
$authorised_values_sth,$input
)
);
push(
@subfields_data,
&create_input(
- $tag, $subfield->{subfield}, '', $index_tag, $tabloop, $record,
+ $tag, $subfield->{subfield}, '', $index_tag, $record,
$authorised_values_sth,$input
)
);
=cut
sub create_input {
- my ( $tag, $subfield, $value, $index_tag, $tabloop, $rec, $authorised_values_sth,$cgi ) = @_;
+ my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi ) = @_;
my $index_subfield = CreateKey(); # create a specifique key for each subfield
name => $tagslib->{$tag}->{$subfield}->{'value_builder'},
});
my $pars= { dbh => $dbh, record => $rec, tagslib => $tagslib,
- id => $subfield_data{id}, tabloop => $tabloop };
+ id => $subfield_data{id} };
$plugin->build( $pars );
if( !$plugin->errstr ) {
$subfield_data{marc_value} = {
push(
@subfields_data,
&create_input(
- $tag, $subfield, $value, $index_tag, $tabloop, $record,
+ $tag, $subfield, $value, $index_tag, $record,
$authorised_values_sth,$input
)
);
push(
@subfields_data,
&create_input(
- $tag, $subfield, $value, $index_tag, $tabloop,
+ $tag, $subfield, $value, $index_tag,
$record, $authorised_values_sth,$input
)
);
push(
@subfields_data,
&create_input(
- $tag, $subfield, '', $index_tag, $tabloop, $record,
+ $tag, $subfield, '', $index_tag, $record,
$authorised_values_sth,$input
)
);
push(
@subfields_data,
&create_input(
- $tag, $subfield->{subfield}, '', $index_tag, $tabloop, $record,
+ $tag, $subfield->{subfield}, '', $index_tag, $record,
$authorised_values_sth,$input
)
);
our $dbh = C4::Context->dbh;
sub generate_subfield_form {
- my ($tag, $subfieldtag, $value, $tagslib,$subfieldlib, $branches, $biblionumber, $temp, $subfields, $i, $restrictededition, $item) = @_;
+ my ($tag, $subfieldtag, $value, $tagslib,$subfieldlib, $branches, $biblionumber, $temp, $i, $restrictededition, $item) = @_;
my $frameworkcode = &GetFrameworkCode($biblionumber);
item_style => 1,
});
my $pars= { dbh => $dbh, record => $temp, tagslib =>$tagslib,
- id => $subfield_data{id}, tabloop => $subfields };
+ id => $subfield_data{id} };
$plugin->build( $pars );
if( !$plugin->errstr ) {
my $class= 'buttonDot'. ( $plugin->noclick? ' disabled': '' );
$value, $tagslib,
$subfield, $libraries,
$biblionumber, $temp,
- \@subfields, $i,
+ $i,
$restrictededition, $current_item,
);
push @subfields, $subfield_data;
sub plugin_javascript {
- my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+ my ($dbh,$record,$tagslib,$field_number) = @_;
my $res="
<script>
function Blur$field_number() {
sub plugin_javascript {
- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+ my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $res = "
<script>
function Clic$field_number(i) {
sub plugin_javascript {
- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+ my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $res = "
<script>
function Clic$field_number(i) {
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
- my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+ my ($dbh,$record,$tagslib,$field_number) = @_;
my $res="
<script>
function Clic$field_number() {
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= "106".(int(rand(100000))+1);
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
- my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+ my ($dbh,$record,$tagslib,$field_number) = @_;
my $res="
<script>
function Clic$field_number() {
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+ my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $res = "
<script>
function Clic$field_number(i) {
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+ my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $res = "
<script>
function Clic$field_number() {
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+ my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $res = "
<script>
function Clic$field_number(i) {
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $res="
<script>
function Clic$field_number(i) {
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name=$field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
=cut
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>
###TODO To rewrite in order to use SearchAuthorities
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
#---- build editors list.
#---- the editor list is built from the "EDITORS" thesaurus
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+ my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $function_name = $field_number;
my $res = "
<script>
=cut
sub plugin_javascript {
- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+ my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $function_name = $field_number;
my $res = "
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+ my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $function_name = $field_number;
my $res = "
<script>
use Koha::SearchEngine::Search;
sub plugin_parameters {
- my ( $dbh, $record, $tagslib, $i, $tabloop ) = @_;
+ my ( $dbh, $record, $tagslib, $i ) = @_;
return "";
}
sub plugin_javascript {
- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+ my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $function_name = $field_number;
my $res = "
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res = "
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res = "
<script>
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
+ my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $function_name = $field_number;
my $res = "
<script>
# includes a typical empty Clic function and plugin subroutine
return mytempfile( <<'HERE'
sub plugin_javascript {
- my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+ my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name = $field_number;
my $res = "
<script type=\"text/javascript\">
});
my $temp;
my $pars= { dbh => $dbh, record => $temp, tagslib => $tagslib,
- id => $subfield_data{id}, tabloop => \@loop_data };
+ id => $subfield_data{id} };
$plugin->build( $pars );
if( !$plugin->errstr ) {
$subfield_data{marc_value} = {
projects / koha-ffzg.git / commitdiff