Bug 15905 - Update unit tests
authorKyle M Hall <kyle@bywatersolutions.com>
Wed, 24 Feb 2016 16:10:48 +0000 (16:10 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Thu, 12 Jan 2017 13:43:23 +0000 (13:43 +0000)
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/db_dependent/Accounts.t

index b24a386..fe3100c 100644 (file)
@@ -24,6 +24,7 @@ use Test::Warn;
 
 use t::lib::TestBuilder;
 
+use Koha::Account;
 use Koha::Account::Lines;
 use Koha::Account::Line;
 
@@ -36,7 +37,6 @@ BEGIN {
 
 can_ok( 'C4::Accounts',
     qw(
-        makepayment
         getnextacctno
         chargelostitem
         manualinvoice
@@ -303,7 +303,7 @@ subtest "Koha::Account::pay particular line tests" => sub {
     is( $line4->amountoutstanding, "4.000000", "Line 4 was not paid" );
 };
 
-subtest "makepayment() tests" => sub {
+subtest "More Koha::Account::pay tests" => sub {
 
     plan tests => 6;
 
@@ -330,13 +330,10 @@ subtest "makepayment() tests" => sub {
 
     is( $rs->count(), 1, 'Accountline created' );
 
+    my $account = Koha::Account->new( { patron_id => $borrowernumber } );
+    my $line = Koha::Account::Lines->find( $accountline->{ accountlines_id } );
     # make the full payment
-    makepayment(
-        $accountline->{ accountlines_id }, $borrowernumber,
-        $accountline->{ accountno },       $amount,
-        $borrowernumber, $branch, 'A payment note' );
-
-    # TODO: someone should write actual tests for makepayment()
+    $account->pay({ lines => [$line], amount => $amount, library_id => $branch, note => 'A payment note' });
 
     my $stat = $schema->resultset('Statistic')->search({
         branch  => $branch,