Bug 29025: Don't prefill userid and password in user creation form
authorDidier Gautheron <didier.gautheron@biblibre.com>
Wed, 15 Sep 2021 05:32:34 +0000 (07:32 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 28 Sep 2021 13:12:45 +0000 (15:12 +0200)
Recent Firefox versions try to prefill userid and password with
logged in user credentials.

To test
1 - Log in staff as user foo password bar
2 - Save user and password in Firefox
3 - Log out
4 - Log in again, log in pop-up must be pre-filled
5 - Open Create a new patron form
6 - At least password field is pre-filled with logged in user's credentials
7 - Apply patch
8 - Redo 4 and 5
9 - Userid and password fields aren't prefilled

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt

index 49ab35f..f303694 100644 (file)
@@ -1184,9 +1184,9 @@ legend:hover {
                                                             [% END %]
                                                         [% ELSE %]
                                                             [% IF ( opduplicate ) %]
-                                                                <input type="password" id="password" name="password" size="20" />
+                                                                <input type="password" id="password" name="password" size="20" autocomplete="new-password" />
                                                             [% ELSE %]
-                                                                <input type="password" id="password" name="password" size="20" value="[% password | html %]" />
+                                                                <input type="password" id="password" name="password" size="20" autocomplete="new-password" value="[% password | html %]" />
                                                             [% END %]
                                                         [% END # /IF ( NoUpdateLogin ) %]
                                                     [% ELSE # IF ( opadd ) %]
@@ -1196,7 +1196,7 @@ legend:hover {
                                                                 <input type="password" id="password" name="password" size="20"  disabled="disabled" value="****" />
                                                             [% ELSE %]
                                                                 [% IF ( opduplicate ) %]
-                                                                    <input type="password" id="password" name="password" size="20" />
+                                                                    <input type="password" id="password" name="password" autocomplete="new-password" size="20" />
                                                                 [% ELSE %]
                                                                     <input type="password" id="password" name="password" size="20" value="****" />
                                                                 [% END %]
@@ -1205,7 +1205,7 @@ legend:hover {
                                                             [% IF ( NoUpdateLogin ) %]
                                                                 <input type="password" id="password" name="password" size="20"  disabled="disabled" value="" />
                                                             [% ELSE %]
-                                                                <input type="password" id="password" name="password" size="20" value="" />
+                                                                <input type="password" id="password" name="password" size="20" autocomplete="new-password" value="" />
                                                             [% END %]
                                                         [% END # /IF ( password ) %]
                                                     [% END # /IF ( opadd )  %]