Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryFi...

Test plan:
0) Do not apply the patch, note the password field is always required
1) Apply the patch
2) Try to add and edit patron with and without "password" in BorrowerMandatoryField, it should always respect this setting
3) Use "Change password" button in patron toolbar, the password field
should be never required here - when leaved blank, the password is
unchanged
4) Play with  minPasswordLength and  RequireStrongPassword preferences,
    to ensure they work as expected

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
index a86a546..df7bb77 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
@@ -137,12 +137,10 @@
             $("#changepasswordf").validate({
                 rules: {
                     newpassword: {
-                        required: true,
                         password_strong: true,
                         password_no_spaces: true
                     },
                     newpassword2: {
-                        required: true,
                         password_match: true
                     }
                 }

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
index cbd3784..d6a3afa 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ -1247,12 +1247,10 @@
             $("#entryform").validate({
                 rules: {
                     password: {
-                        required: true,
                         password_strong: true,
                         password_no_spaces: true
                     },
                     password2: {
-                        required: true,
                         password_match: true
                     }
                 }