Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record delet...

Test plan:
1. Apply patch
2. Check out an item
3. Go to: 'Cataloguing' > 'Batch record deletion'
4. Into the 'Enter a list of record numbers' area paste in the
biblionumber belonging to the checked-out item and that of a biblio without checked out items
5. Submit the form
6. Observe the row of the biblio with checked-out items is highlighted yellow, with a
red cross in the first column
7. Hover over the red cross to see the reason why the biblio cannot be
deleted
8. Observe the row of the biblio without checked-out items is not
highlighted yellow, and does have a checkbox in the first column
9. Click 'Delete selected records'
10. Confirm the biblio without checked-out items is successfully deleted

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
index b846c51..453c5a9 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
@@ -305,12 +305,12 @@
 
           $("#selectall").click();
 
+          //Show a red cross if a biblio cannot be deleted
           [% IF recordtype == 'biblio' %]
             $(".records input:checkbox[data-issues!='0']").each(function(){
-              $(this).attr('title', MSG_CANNOT_BE_DELETED)
-              $(this).prop('disabled', true);
-              $(this).prop('checked', false);
-              $(this).parents('tr').find('td').css('background-color', '#ffff99');
+              $(this).parents('tr').find('td').css('background-color', '#ffff99')
+              $(this).replaceWith("<span class='error'><i class='fa fa-times fa-lg'></i></span>")
+              $(".records i").attr('title', MSG_CANNOT_BE_DELETED)
             });
           [% END %]