Bug 16496 - accountlines.issue_id not set when new overdue is processed
authorKyle M Hall <kyle@bywatersolutions.com>
Tue, 10 May 2016 19:05:00 +0000 (19:05 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 11 May 2016 10:37:12 +0000 (10:37 +0000)
It appears that somehow the adding of issue_id to accountlines for new
fines was missed! This is incredibly important, otherwise UpdateFine
will always create a new fine!

Test Plan:
1) Create a new overdue checkout
2) Run fines.pl to generate an accountline for it
3) Note it has no issue_id
4) Apply this patch
5) Repeat steps 1 and 2
6) Note it now has an issue_id!

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Overdues.pm

index 40f49a7..3f0c32d 100644 (file)
@@ -614,6 +614,7 @@ sub UpdateFine {
                     amountoutstanding => $amount,
                     lastincrement     => $amount,
                     accountno         => $nextaccntno,
+                    issue_id          => $issue_id,
                 }
             )->store();
         }