Bug 26686: Fix sorting of "updated on" and "time created" on notices tab
authorKatrin Fischer <katrin.fischer.83@web.de>
Tue, 20 Oct 2020 16:55:37 +0000 (16:55 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sun, 25 Oct 2020 23:14:41 +0000 (00:14 +0100)
In the patron's account in the staff interface there is a tab
'Notices' that shows all notices sent out to a patron. The
updated on column would not sort at all, but there was also some
markup missing for the time created column.

To test:
- Make sure you have a patron account with some notices, ideally
  with different times and dates
- Verify that the updated on column doesn't sort at all
- Apply patch
- Verify both date columns now sort correctly for different
  DateFormat settings

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt

index bf81f01..deae3b2 100644 (file)
 
 [% IF ( QUEUED_MESSAGES ) %]
     <table id="noticestable">
-       <thead>
-           <tr>
-               <th>Notice</th>
-               <th>Type</th>
-               <th>Status</th>
-        <th>Updated on</th>
-        <th>Time created</th>
-           </tr>
-       </thead>
+        <thead>
+            <tr>
+                <th>Notice</th>
+                <th>Type</th>
+                <th>Status</th>
+                <th class="title-string">Updated on</th>
+                <th class="title-string">Time created</th>
+            </tr>
+        </thead>
        <tbody>
            [% FOREACH QUEUED_MESSAGE IN QUEUED_MESSAGES %]
            <tr>
@@ -74,7 +74,7 @@
             </div>
             [% END %]
         </td>
-        <td><span title="[% QUEUED_MESSAGE.time_status_changed | html %]">[% QUEUED_MESSAGE.updated_on | $KohaDates  with_hours => 1 %]</span></td>
+        <td><span title="[% QUEUED_MESSAGE.updated_on | html %]">[% QUEUED_MESSAGE.updated_on | $KohaDates  with_hours => 1 %]</span></td>
         <td><span title="[% QUEUED_MESSAGE.time_queued | html %]">[% QUEUED_MESSAGE.time_queued | $KohaDates  with_hours => 1 %]</span></td>
            </tr>
            [% END %]