Bug 11891: (follow-up) set DBIC storage flags correctly
authorGalen Charlton <gmc@esilibrary.com>
Tue, 27 May 2014 17:57:33 +0000 (17:57 +0000)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 19 Jun 2014 14:55:23 +0000 (11:55 -0300)
Since we're passing an existing DBI database handle to
DBIC, and that handle doesn't have RaiseError set to true
by default, don't let DBIC override that -- for now.

Test plan: verify that the DB-dependent test suite passes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Koha/Database.pm

index 99888c6..92e83ec 100644 (file)
@@ -45,7 +45,12 @@ __PACKAGE__->mk_accessors(qw( ));
 # database connection from the data given in the current context, and
 # returns it.
 sub _new_schema {
-    my $schema = Koha::Schema->connect( sub { C4::Context->dbh } );
+
+    my $context = C4::Context->new();
+
+    # we are letting C4::Context->dbh not set the RaiseError handle attribute
+    # for now for compatbility purposes
+    my $schema = Koha::Schema->connect( sub { C4::Context->dbh }, { unsafe => 1 } );
     return $schema;
 }