Bug 32030: Fix perlcritic errors

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

diff --git a/Koha/ERM/Providers/EBSCO.pm b/Koha/ERM/Providers/EBSCO.pm
index 3c3ccf8..38217b5 100644 (file)
--- a/Koha/ERM/Providers/EBSCO.pm
+++ b/Koha/ERM/Providers/EBSCO.pm
@@ -223,7 +223,6 @@ sub build_query {
 
     return $url unless $params && %$params;
     while ( my ( $attr, $value ) = each %$params ) {
-        my $their_attr;
         if ( $attr eq 'name' ) {
             $url .= '&search=' . $value;
         }

diff --git a/Koha/REST/V1/ERM/EHoldings/Resources/EBSCO.pm b/Koha/REST/V1/ERM/EHoldings/Resources/EBSCO.pm
index 6afe15d..5f94587 100644 (file)
--- a/Koha/REST/V1/ERM/EHoldings/Resources/EBSCO.pm
+++ b/Koha/REST/V1/ERM/EHoldings/Resources/EBSCO.pm
@@ -76,7 +76,6 @@ sub list {
 
         my ( $per_page, $page ) = $ebsco->build_query_pagination($args);
 
-        my ( $search, $content_type, $selection_type );
         my $additional_params = $ebsco->build_additional_params( $c->req->params->to_hash );
         my $searchfield = 'titlename';
 

diff --git a/Koha/REST/V1/ERM/EHoldings/Titles/EBSCO.pm b/Koha/REST/V1/ERM/EHoldings/Titles/EBSCO.pm
index 73132f8..cc2f414 100644 (file)
--- a/Koha/REST/V1/ERM/EHoldings/Titles/EBSCO.pm
+++ b/Koha/REST/V1/ERM/EHoldings/Titles/EBSCO.pm
@@ -46,7 +46,6 @@ sub list {
 
         my ( $per_page, $page ) = $ebsco->build_query_pagination($args);
 
-        my ( $search, $content_type, $selection_type );
         my $additional_params = $ebsco->build_additional_params( $c->req->params->to_hash );
 
         unless ( defined $additional_params->{publication_title} ) {