Bug 32851: Fix cataloguing/value_builder/unimarc_field_125a.pl
authorJulian Maurice <julian.maurice@biblibre.com>
Fri, 3 Feb 2023 10:58:53 +0000 (11:58 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 29 Mar 2023 10:29:05 +0000 (12:29 +0200)
Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
cataloguing/value_builder/unimarc_field_125a.pl

index c4585d7..2adf950 100755 (executable)
@@ -32,9 +32,10 @@ my ($dbh,$record,$tagslib,$field_number) = @_;
 my $function_name= $field_number;
 my $res="
     <script>
-    function Clic$function_name(i) {
-       defaultvalue=document.getElementById(\"$field_number\").value;
-       newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_125a.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_125a\",'width=1000,height=375,toolbar=false,scrollbars=yes');
+    function Clic$function_name(event) {
+        event.preventDefault();
+        defaultvalue=document.getElementById(event.data.id).value;
+        newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_125a.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_125a\",'width=1000,height=375,toolbar=false,scrollbars=yes');
 
     }
     </script>