Bug 16569 - Message box for "too many checked out" is empty if AllowTooManyOverride...
authorKyle M Hall <kyle@bywatersolutions.com>
Mon, 23 May 2016 14:28:10 +0000 (14:28 +0000)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Mon, 30 May 2016 11:15:26 +0000 (11:15 +0000)
If the limit for number of items checked out is reached, the message box
shows up but is empty.

Test Plan:
1) Disable AllowTooManyOverride
2) Check out items to a patron until the patron has reached the limit
   of checkouts he or she can have
3) Try to check out one more item
4) Note the empty message box
5) Apply this patch
6) Try to check out one more item again
7) Note the message is now visible

Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
C4/Circulation.pm

index 913ec0b..50e6c10 100644 (file)
@@ -934,7 +934,7 @@ sub CanBookBeIssued {
             $needsconfirmation{current_loan_count} = $toomany->{count};
             $needsconfirmation{max_loans_allowed} = $toomany->{max_allowed};
         } else {
-            $needsconfirmation{TOO_MANY} = $toomany->{reason};
+            $issuingimpossible{TOO_MANY} = $toomany->{reason};
             $issuingimpossible{current_loan_count} = $toomany->{count};
             $issuingimpossible{max_loans_allowed} = $toomany->{max_allowed};
         }