Bug 27926: (QA follow-up) Switch to using data-order
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 12 Mar 2021 08:48:59 +0000 (08:48 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 6 Apr 2021 13:56:30 +0000 (15:56 +0200)
This patch switches away from using the title attribute for ordering and
instead uses data-order which is supported in modern DataTables.  This
has the effect of allowing our ordering to continue to work but without
adding the unwanted tooltip on hover.

Test plan
1/ Ensure sorting is still working as expected
2/ Hover over any of the date of birth fields and note that you are not
longer faced with a tooltip.
3/ Signoff

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc

index 1a67d38..3864011 100644 (file)
@@ -4,7 +4,7 @@
         <tr>
             <th>Name</th>
             <th>Card number</th>
-            <th class="title-string">Date of birth</th>
+            <th>Date of birth</th>
             <th>Category</th>
             <th>Library</th>
             <th>Address</th>
@@ -26,7 +26,7 @@
                     <td><a href="[% data_url | url %]">[% borrower.surname | html %], [% borrower.firstname | html %]</a></td>
             [% END %]
                 <td>[% borrower.cardnumber | html %]</td>
-                <td><span title="[% borrower.dateofbirth | html %]">[% INCLUDE 'patron-age.inc' patron = borrower %]</span></td>
+                <td data-order="[% borrower.dateofbirth | html %]">[% INCLUDE 'patron-age.inc' patron = borrower %]</td>
                 <td>[% Categories.GetName( borrower.categorycode ) | html %]</td>
                 <td>[% Branches.GetName( borrower.branchcode ) | html %]</td>
                 <td>[% borrower.address | html %]</td>