Bug 14532: (followup) Use tar's --exclude for simplicity

This patch creates an --exclude definition for the tar command
so it is easier to stack excluded stuff. It does so for the
authority and biblio indexes if --exclude-indexes is passed.

A side effect from this, is that uploads and plugins are still
backed up, as Jonathan noted.

Regards

Edit: Fixed a weird quoting problem.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com

diff --git a/debian/scripts/koha-dump b/debian/scripts/koha-dump
index a67a2c8..ff171a0 100755 (executable)
--- a/debian/scripts/koha-dump
+++ b/debian/scripts/koha-dump
@@ -81,16 +81,17 @@ dump_instance()
     metadump="$backupdir/$name-$date.tar.gz"
     [ "$quiet" = "no" ] && echo "* configs, logs to $metadump"
 
-    zebra_files=""
-    if [ "$exclude_indexes" = "no" ]; then
-        zebra_files="var/lib/koha/$name"
+    if [ "$exclude_indexes" = "yes" ]; then
+        excludes="--exclude=var/lib/koha/$name/biblios \
+                  --exclude=var/lib/koha/$name/authorities"
     fi
 
-    tar -C / -czf "$metadump" \
+    tar -czf "$metadump" -C / $excludes \
         "etc/koha/sites/$name" \
         "etc/apache2/sites-available/$instancefile" \
         "etc/apache2/sites-enabled/$instancefile" \
-        "var/log/koha/$name" ${zebra_files:+"$zebra_files"}
+        "var/lib/koha/$name" \
+        "var/log/koha/$name"
 
     [ "$quiet" = "no" ] && echo "Done."
 }