Bug 16717: Remove hardcoded category from Holds.t

There is actually no need to use the hardcoded patron category S in
this test.

Test plan:
Run t/db_dependent/Holds.t.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Test passes OK
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t
index 7e490e3..b368481 100755 (executable)
--- a/t/db_dependent/Holds.t
+++ b/t/db_dependent/Holds.t
@@ -34,11 +34,7 @@ my $dbh     = C4::Context->dbh;
 my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode };
 my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode };
 
-# This test assumes we have a category S. This statement helps.
-$builder->build({
-    source => 'Category',
-    value  => { categorycode => 'S', category_type => 'S' },
-});
+my $category = $builder->build({ source => 'Category' })->{categorycode};
 
 my $borrowers_count = 5;
 
@@ -64,7 +60,7 @@ foreach (1..$borrowers_count) {
     my $borrowernumber = AddMember(
         firstname =>  'my firstname',
         surname => 'my surname ' . $_,
-        categorycode => 'S',
+        categorycode => $category,
         branchcode => $branch_1,
     );
     push @borrowernumbers, $borrowernumber;