Bug 32349: Remove TEST_QA

There is an env var that we are passing from koha-testing-docker, TEST_QA.
It's used in Koha from a single test file, t/00-testcritic.t.
If not set, no test is run.

Do we really need this? libtest-perl-critic-perl is packaged and automatically installed.

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0adc264edb3172f7d2dca771efbe19d15f240d8f)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>

diff --git a/t/00-testcritic.t b/t/00-testcritic.t
index 4c7f441..cd3a7af 100755 (executable)
--- a/t/00-testcritic.t
+++ b/t/00-testcritic.t
@@ -1,18 +1,11 @@
 #!/usr/bin/env perl
 
 # This script can be used to run perlcritic on perl files in koha
-# The script is purely optional requiring Test::Perl::Critic to be installed 
-# and the environment variable TEST_QA to be set
 
 use Modern::Perl;
 use Test::More;
 use English qw(-no_match_vars);
 
-if ( not $ENV{TEST_QA} ) {
-    my $msg = 'Author test. Set $ENV{TEST_QA} to a true value to run';
-    plan( skip_all => $msg );
-}
-
 eval { require Test::Perl::Critic; };
 
 if ( $EVAL_ERROR ) {