Bug 18547: Add tests

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t b/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
index ec76403..ef498d8 100755 (executable)
--- a/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
+++ b/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
@@ -7,9 +7,10 @@ use C4::Items;
 use C4::Circulation;
 use Koha::IssuingRule;
 
-use Test::More tests => 4;
+use Test::More tests => 5;
 
 use t::lib::TestBuilder;
+use t::lib::Mocks;
 
 BEGIN {
     use_ok('C4::Reserves');
@@ -24,6 +25,10 @@ my $builder = t::lib::TestBuilder->new;
 my $library1 = $builder->build({
     source => 'Branch',
 });
+my $library2 = $builder->build({
+    source => 'Branch',
+});
+
 
 # Now, set a userenv
 C4::Context->_new_userenv('xxx');
@@ -52,6 +57,7 @@ my ( $itemtype ) = @{ $dbh->selectrow_arrayref("SELECT itemtype FROM itemtypes L
 my $borrowernumber1 = $borrower1->{borrowernumber};
 my $borrowernumber2 = $borrower2->{borrowernumber};
 my $library_A = $library1->{branchcode};
+my $library_B = $library2->{branchcode};
 
 $dbh->do("INSERT INTO biblio (frameworkcode, author, title, datecreated) VALUES ('', 'Koha test', '$bib_title', '2011-02-01')");
 
@@ -104,7 +110,7 @@ $rule->store();
 my $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
 is( $is, 0, "Item cannot be held, 2 items available" );
 
-AddIssue( $borrower2, $item1->{barcode} );
+my $issue1 = AddIssue( $borrower2, $item1->{barcode} );
 
 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
 is( $is, 0, "Item cannot be held, 1 item available" );
@@ -114,5 +120,84 @@ AddIssue( $borrower2, $item2->{barcode} );
 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
 is( $is, 1, "Item can be held, no items available" );
 
+AddReturn( $item1->{barcode} );
+
+{ # Remove the issue for the first patron, and modify the branch for item1
+    subtest 'IsAvailableForItemLevelRequest behaviours depending on ReservesControlBranch + holdallowed' => sub {
+        plan tests => 2;
+
+        my $hold_allowed_from_home_library = 1;
+        my $hold_allowed_from_any_libraries = 2;
+        my $sth_delete_rules = $dbh->prepare(q|DELETE FROM default_circ_rules|);
+        my $sth_insert_rule = $dbh->prepare(q|INSERT INTO default_circ_rules(singleton, maxissueqty, maxonsiteissueqty, holdallowed, hold_fulfillment_policy, returnbranch) VALUES ('singleton', NULL, NULL, ?, 'any', 'homebranch');|);
+
+        subtest 'Item is checked out from the same library' => sub {
+            plan tests => 4;
+
+            Koha::Items->find( $item1->{itemnumber} )->set({homebranch => $library_B, holdingbranch => $library_B })->store;
+            $item1 = GetItem( $itemnumber1 );
+
+            {
+                $sth_delete_rules->execute;
+                $sth_insert_rule->execute( $hold_allowed_from_home_library );
+
+                t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
+                $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
+                is( $is, 1, "Hold allowed from home library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library => the hold is allowed at item level" );
+
+                t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
+                $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
+                is( $is, 1, "Hold allowed from home library + ReservesControlBranch=PatronLibrary, One item is available at the same library => the hold is allowed at item level" );
+            }
+
+            {
+                $sth_delete_rules->execute;
+                $sth_insert_rule->execute( $hold_allowed_from_any_libraries );
+
+                t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
+                $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
+                is( $is, 0, "Hold allowed from any library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library => the hold is allowed at item level" );
+
+                t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
+                $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
+                is( $is, 0, "Hold allowed from any library + ReservesControlBranch=PatronLibrary, One item is available at the same library => the hold is allowed at item level" );
+            }
+        };
+
+        subtest 'Item is checked out from the another library' => sub {
+            plan tests => 4;
+
+            Koha::Items->find( $item1->{itemnumber} )->set({homebranch => $library_A, holdingbranch => $library_A })->store;
+            $item1 = GetItem( $itemnumber1 );
+
+            {
+                $sth_delete_rules->execute;
+                $sth_insert_rule->execute( $hold_allowed_from_home_library );
+
+                t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
+                $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
+                is( $is, 0, "Hold allowed from home library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library => the hold is allowed at item level" );
+
+                t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
+                $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
+                is( $is, 0, "Hold allowed from home library + ReservesControlBranch=PatronLibrary, One item is available at the same library => the hold is allowed at item level" );
+            }
+
+            {
+                $sth_delete_rules->execute;
+                $sth_insert_rule->execute( $hold_allowed_from_any_libraries );
+
+                t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
+                $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
+                is( $is, 0, "Hold allowed from any library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library => the hold is allowed at item level" );
+
+                t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
+                $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
+                is( $is, 0, "Hold allowed from any library + ReservesControlBranch=PatronLibrary, One item is available at the same library => the hold is allowed at item level" );
+            }
+        };
+    };
+}
+
 # Cleanup
 $schema->storage->txn_rollback;