Bug 20838: Add 2 small tests to check ref
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 1 Jun 2018 14:39:52 +0000 (11:39 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 4 Jun 2018 17:40:36 +0000 (13:40 -0400)
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
t/db_dependent/LibraryGroups.t

index 02e9817..4b60777 100644 (file)
@@ -4,7 +4,7 @@ use Modern::Perl;
 
 use List::MoreUtils 'any';
 
-use Test::More tests => 17;
+use Test::More tests => 19;
 
 use t::lib::TestBuilder;
 
@@ -120,7 +120,9 @@ my $groupX2_library6 = Koha::Library::Group->new({ parent_id => $groupX2->id,  b
 my @branchcodes = sort( $library1->{branchcode}, $library2->{branchcode} );
 my @group_branchcodes = sort( map { $_->branchcode } $groupX->libraries->as_list );
 is_deeply( \@branchcodes, \@group_branchcodes, "Group libraries are returned correctly" );
+is( ref($groupX->libraries), 'Koha::Libraries', '->libraries should return a Koha::Libraries iterator' );
 
 @branchcodes = sort( $library1->{branchcode}, $library2->{branchcode}, $library3->{branchcode}, $library4->{branchcode}, $library5->{branchcode}, $library6->{branchcode} );
 @group_branchcodes = sort( map { $_->branchcode } $groupX->all_libraries );
 is_deeply( \@branchcodes, \@group_branchcodes, "Group all_libraries are returned correctly" );
+is( ref(($groupX->all_libraries)[0]), 'Koha::Library', '->all_libraries should return a list of Koha::Library - in the future it should be fixed to return a Koha::Libraries iterator instead'); # FIXME