Bug 7825: (follow-up) fix the force value for the bootstrap theme

If the pref was set to 'force', the item selection was not shown.
.copiesrow should be hidden before showing specific #copiesrow_ID

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.

Works on template level, tested with Boostrap and Prog theme
with all 3 possible seetings of OPACItemHolds:

1) no = offer only title level holds
2) yes = offer both title and item level holds
3) force = offer only item level holds

Also ran some additional tests on the Boostrap theme with
deactivated Javascript.

Note: I like this, but I think when "force" is selected the
item list needs to be shown by default. I am also not happy about
preselecting the first item.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
index 5b1e313..e82540c 100644 (file)
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
@@ -424,15 +424,6 @@
             }
         });
 
-        [% FOREACH bibitemloo IN bibitemloop %]
-          [% IF bibitemloo.holdable %]
-            [% IF OPACItemHolds == 'force' %]
-              $("#copiesrow_[% bibitemloo.biblionumber %]").show();
-            [% END %]
-          [% END %]
-        [% END %]
-
-
         // click on a first td check the confirmjs checkbox
         $("td.hold").click(function(e){
           if(e.target.tagName.toLowerCase() == 'td'){
@@ -446,6 +437,14 @@
         // Hides all 'specific copy' table rows on load.
         $(".copiesrow").hide();
 
+        [% FOREACH bibitemloo IN bibitemloop %]
+          [% IF bibitemloo.holdable %]
+            [% IF OPACItemHolds == 'force' %]
+              $("#copiesrow_[% bibitemloo.biblionumber %]").show();
+            [% END %]
+          [% END %]
+        [% END %]
+
         // Insert reasons for forced hold notes
         $(".forcenotesreason").each(function(){
             biblioNum = suffixOf($(this).attr("id"), "_");