Bug 27266: (QA follow-up) Rename to get_marc_authors

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
index df74150..ef0e767 100644 (file)
--- a/Koha/Biblio.pm
+++ b/Koha/Biblio.pm
@@ -966,16 +966,16 @@ sub get_marc_notes {
     return \@marcnotes;
 }
 
-=head3 get_authors_from_MARC
+=head3 get_marc_authors
 
-    my $authors = $biblio->get_authors_from_MARC;
+    my $authors = $biblio->get_marc_authors;
 
 Get all authors from the MARC record and returns them in an array.
 The authors are stored in different fields depending on MARC flavour
 
 =cut
 
-sub get_authors_from_MARC {
+sub get_marc_authors {
     my ( $self, $params ) = @_;
 
     my ( $mintag, $maxtag, $fields_filter );

diff --git a/basket/basket.pl b/basket/basket.pl
index a516953..eace7fe 100755 (executable)
--- a/basket/basket.pl
+++ b/basket/basket.pl
@@ -72,7 +72,7 @@ foreach my $biblionumber ( @bibs ) {
     my $biblio           = Koha::Biblios->find( $biblionumber );
     my $record           = &GetMarcBiblio({ biblionumber => $biblionumber });
     my $marcnotesarray   = $biblio->get_marc_notes({ marcflavour => $marcflavour });
-    my $marcauthorsarray = $biblio->get_authors_from_MARC;
+    my $marcauthorsarray = $biblio->get_marc_authors;
     my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
     my $marcseriesarray  = GetMarcSeries  ($record,$marcflavour);
     my $marcurlsarray    = GetMarcUrls    ($record,$marcflavour);

diff --git a/basket/sendbasket.pl b/basket/sendbasket.pl
index 6110a60..a393add 100755 (executable)
--- a/basket/sendbasket.pl
+++ b/basket/sendbasket.pl
@@ -78,7 +78,7 @@ if ( $email_add ) {
         my $record           = GetMarcBiblio({
             biblionumber => $biblionumber,
             embed_items => 1 });
-        my $marcauthorsarray = $biblio->get_authors_from_MARC;
+        my $marcauthorsarray = $biblio->get_marc_authors;
         my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
 
         my @items = GetItemsInfo( $biblionumber );

diff --git a/opac/opac-basket.pl b/opac/opac-basket.pl
index a379713..fe50339 100755 (executable)
--- a/opac/opac-basket.pl
+++ b/opac/opac-basket.pl
@@ -94,7 +94,7 @@ foreach my $biblionumber ( @bibs ) {
     $record_processor->process($record);
     next unless $record;
     my $marcnotesarray   = $biblio->get_marc_notes({ marcflavour => $marcflavour, opac => 1 });
-    my $marcauthorsarray = $biblio->get_authors_from_MARC;
+    my $marcauthorsarray = $biblio->get_marc_authors;
     my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
     my $marcseriesarray  = GetMarcSeries  ($record,$marcflavour);
     my $marcurlsarray    = GetMarcUrls    ($record,$marcflavour);

diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
index 098ece2..83c2cc5 100755 (executable)
--- a/opac/opac-detail.pl
+++ b/opac/opac-detail.pl
@@ -784,7 +784,7 @@ if (scalar(@itemloop) == 0 || scalar(@otheritemloop) == 0) {
 }
 
 my $marcnotesarray = $biblio->get_marc_notes({ marcflavour => $marcflavour, opac => 1 });
-my $marcauthorsarray = $biblio->get_authors_from_MARC;
+my $marcauthorsarray = $biblio->get_marc_authors;
 
 if( C4::Context->preference('ArticleRequests') ) {
     my $patron = $borrowernumber ? Koha::Patrons->find($borrowernumber) : undef;

diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl
index cb43af3..ade073a 100755 (executable)
--- a/opac/opac-sendbasket.pl
+++ b/opac/opac-sendbasket.pl
@@ -87,7 +87,7 @@ if ( $email_add ) {
             embed_items  => 1,
             opac         => 1,
             borcat       => $borcat });
-        my $marcauthorsarray = $biblio->get_authors_from_MARC;
+        my $marcauthorsarray = $biblio->get_marc_authors;
         my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
 
         my @items = GetItemsInfo( $biblionumber );

diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl
index c8f9ed4..bf593b7 100755 (executable)
--- a/opac/opac-sendshelf.pl
+++ b/opac/opac-sendshelf.pl
@@ -96,7 +96,7 @@ if ( $email ) {
         my $fw               = GetFrameworkCode($biblionumber);
         my $dat              = GetBiblioData($biblionumber);
 
-        my $marcauthorsarray = $biblio->get_authors_from_MARC;
+        my $marcauthorsarray = $biblio->get_marc_authors;
         my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
 
         my @items = GetItemsInfo( $biblionumber );

diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t
index a666be2..a2c0e52 100755 (executable)
--- a/t/db_dependent/Koha/Biblio.t
+++ b/t/db_dependent/Koha/Biblio.t
@@ -859,7 +859,7 @@ subtest 'current_checkouts() and old_checkouts() tests' => sub {
     $schema->storage->txn_rollback;
 };
 
-subtest 'get_authors_from_MARC() tests' => sub {
+subtest 'get_marc_authors() tests' => sub {
 
     plan tests => 1;
 
@@ -882,7 +882,7 @@ subtest 'get_authors_from_MARC() tests' => sub {
     C4::Biblio::ModBiblio( $record, $biblio->biblionumber );
     $biblio = Koha::Biblios->find( $biblio->biblionumber );
 
-    is( 4, @{$biblio->get_authors_from_MARC}, 'get_authors_from_MARC retrieves correct number of author subfields' );
+    is( 4, @{$biblio->get_marc_authors}, 'get_marc_authors retrieves correct number of author subfields' );
 
     $schema->storage->txn_rollback;
 };

diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl
index 58b4d14..dfd4be1 100755 (executable)
--- a/virtualshelves/sendshelf.pl
+++ b/virtualshelves/sendshelf.pl
@@ -78,7 +78,7 @@ if ($to_address) {
         my $record           = GetMarcBiblio({
             biblionumber => $biblionumber,
             embed_items  => 1 });
-        my $marcauthorsarray = $biblio->get_authors_from_MARC;
+        my $marcauthorsarray = $biblio->get_marc_authors;
         my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
 
         my @items = GetItemsInfo($biblionumber);