Bug 12274: handle closed invoices properly on invoice details page
authorJacek Ablewicz <abl@biblos.pk.edu.pl>
Sat, 17 May 2014 08:30:15 +0000 (10:30 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 21 May 2014 18:58:36 +0000 (18:58 +0000)
Trivial fix for small regression (closed invoices are displayed as
"Open" on details page, and it's not possible to reopen the closed
invoice using "Save" button) introduced by bug 10613.

Test plan:

1) Create and close some invoices
2) Note that closed invoices are erroneously displayed as "Open"
on individual invoice[s] details page
3) Apply patch
4) Check previously closed invoices; their status on details page
should now be properly displayed as "Closed on ..." (and an option
for reopening would reappear as well)
5) Ensure that "Close" / "Reopen" checkboxes followed by "Save" button
do work as expected for individual open / closed invoices respectivelly.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
acqui/invoice.pl

index 95065c9..84b7834 100755 (executable)
@@ -151,7 +151,7 @@ $template->param(
     booksellerid     => $details->{'booksellerid'},
     datereceived     => $details->{'datereceived'},
     billingdate      => C4::Dates->new($details->{'billingdate'}, "iso")->output(),
-    invoiceclosedate => $details->{'invoiceclosedate'},
+    invoiceclosedate => $details->{'closedate'},
     shipmentcost     => $details->{'shipmentcost'},
     orders_loop      => \@orders_loop,
     foot_loop        => \@foot_loop,