Bug 18184: Show frequency and numbering pattern info when viewing all subs attached...
authorAleisha Amohia <aleishaamohia@hotmail.com>
Tue, 4 Apr 2017 23:51:16 +0000 (23:51 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 25 Oct 2017 15:14:39 +0000 (12:14 -0300)
To test:
1) Go to Serials, find a serial with more than one subscription
2) Click Serial collection
3) Notice how Frequency and Numbering pattern are filled out correctly
4) Click 'see any sub attached to this biblio'
5) Notice how Frequency and Numbering pattern are now missing info
6) Apply patch and refresh page
7) Confirm Frequency and Numbering pattern now show as expected

Sponsored-by: Catalyst IT
Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
serials/serials-collection.pl

index 5182cbd..e9cb3fd 100755 (executable)
@@ -134,7 +134,13 @@ if (@subscriptionid){
   $subscriptions=PrepareSerialsData(\@subscriptioninformation);
   $subscriptioncount = CountSubscriptionFromBiblionumber($subscriptiondescs->[0]{'biblionumber'});
 } else {
-  $subscriptiondescs = GetSubscriptionsFromBiblionumber($biblionumber) ;
+  $subscriptiondescs = GetSubscriptionsFromBiblionumber($biblionumber);
+  foreach my $s (@$subscriptiondescs) {
+    my $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($s->{periodicity});
+    my $numberpattern = C4::Serials::Numberpattern::GetSubscriptionNumberpattern($s->{numberpattern});
+    $s->{frequency} = $frequency;
+    $s->{numberpattern} = $numberpattern;
+  }
   my $subscriptioninformation = GetFullSubscriptionsFromBiblionumber($biblionumber);
   $subscriptions=PrepareSerialsData($subscriptioninformation);
 }