Bug 11541: (follow-up) update tests

This patch updates some of the tests to more clearly
check that fields in the C4::Installer object are getting
set correctly from the context.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

diff --git a/t/Installer.t b/t/Installer.t
index cc786d8..1fc9fc4 100644 (file)
--- a/t/Installer.t
+++ b/t/Installer.t
@@ -13,12 +13,11 @@ BEGIN {
         use_ok('C4::Installer');
 }
 
-my $self;
 ok ( my $installer = C4::Installer->new(), 'Testing NewInstaller' );
-ok ( my $class = {shift}, 'Testing Shift' );
-ok ( $self->{'dbname'} = C4::Context->config("database"), 'Testing DbName' );
-ok ( $self->{'dbms'} = C4::Context->config("db_scheme") ? C4::Context->config("db_scheme") : "mysql", 'Testing DbScheme' );
-ok ( $self->{'hostname'} = C4::Context->config("hostname"), 'Testing Hostname' );
-ok ( $self->{'port'} = C4::Context->config("port"), 'Testing Port' );
-ok ( $self->{'user'} = C4::Context->config("user"), 'Testing User' );
-ok ( $self->{'password'} = C4::Context->config("pass"), 'Testing Password' );
+is ( ref $installer, 'C4::Installer', 'Testing class of object' );
+is ( $installer->{'dbname'},   C4::Context->config("database"), 'Testing DbName' );
+is ( $installer->{'dbms'},     C4::Context->config("db_scheme") ? C4::Context->config("db_scheme") : "mysql", 'Testing DbScheme' );
+is ( $installer->{'hostname'}, C4::Context->config("hostname"), 'Testing Hostname' );
+is ( $installer->{'port'},     C4::Context->config("port"), 'Testing Port' );
+is ( $installer->{'user'},     C4::Context->config("user"), 'Testing User' );
+is ( $installer->{'password'}, C4::Context->config("pass"), 'Testing Password' );