Bug 16947: Can not modify patron messaging preferences

To verify:
- Set syspref 'EnhancedMessagingPreferences' to 'Allow'
- In staff client, go to a patron's detail page
- Edit Patron messaging preferences (using link below table)
- Save
Result: Form does not save, stays open
JavaScript error in intranet-tmpl/prog/js/members.js line 107
TypeError: document.form.password is undefined

To test:
- Apply patch
- Repeat steps above
- Verify that messaging preferences save as expected
- Verify that other patron modifications work as before

NOTE: remember to force reload of the javascripts.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/js/members.js b/koha-tmpl/intranet-tmpl/prog/js/members.js
index d300d92..c90d8af 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/js/members.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/members.js
@@ -103,18 +103,19 @@ function check_form_borrowers(nav){
             }
         }
     }
-
-    if ( document.form.password.value != document.form.password2.value ){
+    if ( document.form.password ) {
+        if ( document.form.password.value != document.form.password2.value ){
             if ( message_champ !== '' ){
                 message_champ += "\n";
             }
             message_champ+= MSG_PASSWORD_MISMATCH;
             statut=1;
-    }
+        }
 
-    if ( ! check_password( document.form.password.value ) ) {
-        message_champ += MSG_PASSWORD_CONTAINS_TRAILING_SPACES;
-        statut = 1;
+        if ( ! check_password( document.form.password.value ) ) {
+            message_champ += MSG_PASSWORD_CONTAINS_TRAILING_SPACES;
+            statut = 1;
+        }
     }
 
     //patrons form to test if you checked no to the question of double