Bug 21413: Fix condition to avoid operator bnding isssues

The original WHERE condition wasn't enclosed in parenthesis, and hence
was subject to binding precedence issues in some situations.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/C4/Items.pm b/C4/Items.pm
index 0916706..cf05a4c 100644 (file)
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -878,7 +878,7 @@ sub GetItemsForInventory {
 
     if ( $ignore_waiting_holds ) {
         $query .= "LEFT JOIN reserves ON items.itemnumber = reserves.itemnumber ";
-        push( @where_strings, q{reserves.found != 'W' OR reserves.found IS NULL} );
+        push( @where_strings, q{(reserves.found != 'W' OR reserves.found IS NULL)} );
     }
 
     if ( @where_strings ) {

diff --git a/t/db_dependent/Items/GetItemsForInventory.t b/t/db_dependent/Items/GetItemsForInventory.t
index d2bd9f7..af136dc 100755 (executable)
--- a/t/db_dependent/Items/GetItemsForInventory.t
+++ b/t/db_dependent/Items/GetItemsForInventory.t
@@ -87,6 +87,7 @@ subtest 'Skip items with waiting holds' => sub {
                 homebranch       => $library->id,
                 holdingbranch    => $library->id,
                 itype            => $itemtype->itemtype,
+                reserves         => undef
             }
         }
     );
@@ -99,6 +100,7 @@ subtest 'Skip items with waiting holds' => sub {
                 homebranch       => $library->id,
                 holdingbranch    => $library->id,
                 itype            => $itemtype->itemtype,
+                reserves         => undef
             }
         }
     );