Bug 32694: Fix value of 'Keep current' option in receiving
authorNick Clemens <nick@bywatersolutions.com>
Fri, 20 Jan 2023 20:18:27 +0000 (20:18 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Wed, 1 Feb 2023 19:11:47 +0000 (19:11 +0000)
This patch restores missing template toolkit markers around the variable

To test:
1 - Order an item in a basket
2 - Close the basket
3 - Attempt to receive the item, leaving budget as 'Keep current'
4 - 500 Error:
C4::Acquisition::ModReceiveOrder(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (koha_cclsny.aqorders, CONSTRAINT aqorders_budget_id_fk FOREIGN KEY (budget_id) REFERENCES aqbudgets (budget_id) ON DELETE CASCADE ON UPDATE CASCADE) at /usr/share/koha/intranet/cgi-bin/acqui/finishreceive.pl line 120
5 - Apply patch
6 - Receive order successfully!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9531a82e97661ce7013a8e9a64b8d5c4d2fa3635)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
(cherry picked from commit 6f0bbc2afc4a592dc3d1cefb73b24a6cac4ea8ae)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt

index 1168da2..a1b9af6 100644 (file)
             [% END %]
             <select class="select2" id="bookfund" name="bookfund">
                 <optgroup label="Current">
-                        <option value="order.fund.budget.id" selected="selected" data-sort1-authcat="[% order.fund.sort1_authcat | html %]" data-sort2-authcat="[% order.fund.sort2_authcat | html %]">
+                        <option value="[% order.fund.budget.id %]" selected="selected" data-sort1-authcat="[% order.fund.sort1_authcat | html %]" data-sort2-authcat="[% order.fund.sort2_authcat | html %]">
                             Keep current ([% order.fund.budget_name | html %])</option>
                 </optgroup>
             [% FOREACH budget_period_id IN budget_loops.keys %]