Bug 16955: Do not clear from cache when adding a new framework
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 2 Aug 2016 08:43:01 +0000 (09:43 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Thu, 18 Aug 2016 15:48:52 +0000 (15:48 +0000)
There are several issues with these lines:
1/ $cache is not defined correctly and it not visible inside
duplicate_framework
2/ $frameworkcode is a wrong c/p, it should be $newframeworkcode
3/ these calls are not needed. As we are creating a new framework, the cache
should be empty...

This patch will simply remove these calls

Test plan:
Duplicate a framework and confirm that you do not get any error in your
logs.

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
admin/marctagstructure.pl

index 27d9592..0f27ac0 100755 (executable)
@@ -357,9 +357,5 @@ sub duplicate_framework {
        while ( my ($frameworkcode, $tagfield, $tagsubfield, $liblibrarian, $libopac, $repeatable, $mandatory, $kohafield, $tab, $authorised_value, $thesaurus_category, $value_builder, $seealso,$hidden) = $sth->fetchrow) {
            $sth_insert->execute($newframeworkcode, $tagfield, $tagsubfield, $liblibrarian, $libopac, $repeatable, $mandatory, $kohafield, $tab, $authorised_value, $thesaurus_category, $value_builder, $seealso, $hidden);
        }
-    $cache->clear_from_cache("MarcStructure-0-$newframeworkcode");
-    $cache->clear_from_cache("MarcStructure-1-$newframeworkcode");
-    $cache->clear_from_cache("default_value_for_mod_marc-$frameworkcode");
-    $cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode");
 }