Bug 12307: Catalog details page displaying incorrect status for items with itemtype...

The template markup that controls that status column for
the items table in catalogue/detail.pl does not account
for the itemtypes.notforloan flag.

Test Plan:
1) Find an item that is currently available
2) Go to the itemtype editor and mark that itemtype of that item
   as being not for loan
3) Browse to the catalog details page for that item's record
4) Note the item status is still "Available"
5) Apply this patch
6) Reload the catalog details page
7) Note the item status is now "Not for loan"

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Good catch! Works as described, no problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index fe8d32e..9e17a40 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -609,7 +609,7 @@ function verify_images() {
                             [% END %]
                         [% END %]
 
-                        [% IF ( item.itemnotforloan ) %]
+                        [% IF ( item.itemnotforloan || item.notforloan_per_itemtype ) %]
                             Not for loan
                             [% IF ( item.notforloanvalue ) %]
                                 ([% item.notforloanvalue %])
@@ -643,7 +643,16 @@ function verify_images() {
                                 [% END %]
                             [% END %]
                         [% END %]
-                        [% UNLESS ( item.itemnotforloan or item.onloan or item.itemlost or item.withdrawn or item.damaged or item.transfertwhen or item.reservedate ) %]
+                        [% UNLESS (
+                               item.itemnotforloan
+                            or item.notforloan_per_itemtype
+                            or item.onloan
+                            or item.itemlost
+                            or item.withdrawn
+                            or item.damaged
+                            or item.transfertwhen
+                            or item.reservedate
+                        ) %]
                             Available
                         [% END %]