Bug 14653: Acq planning filter always use default active period
authorFridolin Somers <fridolin.somers@biblibre.com>
Thu, 6 Aug 2015 08:49:03 +0000 (10:49 +0200)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 13 Oct 2015 15:19:30 +0000 (12:19 -0300)
In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period.
As said in code :
- IF PERIOD_ID IS DEFINED,  GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT
my $period = GetBudgetPeriod($budget_period_id);

This patch corrects the filter form.

Test plan :
- Create an active budget "B_ACTIVE" with 1 fund
- Create an inactive budget "B_OLD" with 3 funds
- Go to "B_OLD" planning by libraries
- You see 3 funds
- In filter form, select "by months" in "Select planning type"
=> Without patch, you see planning of "B_ACTIVE" with 1 fund
=> Without patch, you see planning of "B_OLD" with 3 funds

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt

index 2510d04..2b16b64 100644 (file)
         <label for="show_actual">Show actual/estimated values</label>
     </li>
     </ol>
-<fieldset class="action">
-        <input type="submit" name="option_submit" value="Submit" /></fieldset>
+    <fieldset class="action">
+        <input type="submit" name="option_submit" value="Submit" />
+        <input type="hidden" name="budget_period_id" value="[% budget_period_id %]" />
+    </fieldset>
 </fieldset>
 </form>
 [% IF ( budget_lines ) %]