Bug 12820: [QA Followup] Tab and whitespace cleanup
authorKyle M Hall <kyle@bywatersolutions.com>
Fri, 20 Mar 2015 13:09:45 +0000 (09:09 -0400)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Wed, 25 Mar 2015 14:26:12 +0000 (11:26 -0300)
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/SIP/Sip/MsgType.pm

index cf3a737..5ef7465 100644 (file)
@@ -514,19 +514,18 @@ sub handle_checkout {
     my $fee_ack = $fields->{(FID_FEE_ACK)};
 
 
-    if ($no_block eq 'Y') {
-       # Off-line transactions need to be recorded, but there's
-       # not a lot we can do about it
-       syslog("LOG_WARNING", "received no-block checkout from terminal '%s'",
-              $account->{id});
-
-       $status = $ils->checkout_no_block($patron_id, $item_id,
-                                         $sc_renewal_policy,
-                                         $trans_date, $nb_due_date);
-    } else {
-       # Does the transaction date really matter for items that are
-       # checkout out while the terminal is online?  I'm guessing 'no'
-               $status = $ils->checkout($patron_id, $item_id, $sc_renewal_policy, $fee_ack);
+    if ( $no_block eq 'Y' ) {
+
+        # Off-line transactions need to be recorded, but there's
+        # not a lot we can do about it
+        syslog( "LOG_WARNING", "received no-block checkout from terminal '%s'", $account->{id} );
+
+        $status = $ils->checkout_no_block( $patron_id, $item_id, $sc_renewal_policy, $trans_date, $nb_due_date );
+    }
+    else {
+        # Does the transaction date really matter for items that are
+        # checkout out while the terminal is online?  I'm guessing 'no'
+        $status = $ils->checkout( $patron_id, $item_id, $sc_renewal_policy, $fee_ack );
     }
 
     $item = $status->item;
@@ -601,14 +600,15 @@ sub handle_checkout {
            }
        }
     }
-       if ($protocol_version >= 2) {
-           # Financials : return irrespective of ok status
-        if ($status->fee_amount) {
-            $resp .= add_field(FID_FEE_AMT, $status->fee_amount);
-            $resp .= maybe_add(FID_CURRENCY, $status->sip_currency);
-            $resp .= maybe_add(FID_FEE_TYPE, $status->sip_fee_type);
-            $resp .= maybe_add(FID_TRANSACTION_ID,
-                $status->transaction_id);
+
+    if ( $protocol_version >= 2 ) {
+
+        # Financials : return irrespective of ok status
+        if ( $status->fee_amount ) {
+            $resp .= add_field( FID_FEE_AMT, $status->fee_amount );
+            $resp .= maybe_add( FID_CURRENCY,       $status->sip_currency );
+            $resp .= maybe_add( FID_FEE_TYPE,       $status->sip_fee_type );
+            $resp .= maybe_add( FID_TRANSACTION_ID, $status->transaction_id );
         }
     }