Bug 10297 - categorycode and branchcode should be required when adding patrons
authorOwen Leonard <oleonard@myacpl.org>
Mon, 10 Jun 2013 15:14:41 +0000 (11:14 -0400)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 12 Jun 2013 18:51:54 +0000 (11:51 -0700)
categorycode and branchcode should show as required under all
circumstances, not just when they are included in the
BorrowerMandatoryField system preference. This patch adds the correct
classes and hints to those fields.

To test, view the patron entry form for a new or existing patron.
Category and Library should show that they are required.

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt

index 6b293f1..1bb8e3e 100644 (file)
         [% END %]
         [% UNLESS nobranchcode %]
     <li>
-      [%- IF ( mandatorybranchcode ) -%]
-        <label for="branchcode" class="required">
-      [%- ELSE -%]
-        <label for="branchcode">
-      [%- END -%]
-      Library:</label>
-      <select name="branchcode" size="1" id="branchcode">
+        <label for="branchcode" class="required">Library:</label>
+        <select name="branchcode" size="1" id="branchcode">
         [%- FOREACH branchloo IN branchloop %]
           [% IF ( branchloo.selected ) -%]
             <option value="[% branchloo.branchcode %]" selected="selected">[% branchloo.branchname %]</option>
           [%- END -%]
         [%- END %]
       </select>
-      [% IF ( mandatorybranchcode ) -%]
       <span class="required">Required</span>
-      [%- END %]
     </li>
         [% END %]
     <li>
-        <label for="categorycode">Category: </label>
+        <label for="categorycode" class="required">Category: </label>
         <select id="categorycode" name="categorycode" onchange="update_category_code(this);">
         [% FOREACH typeloo IN typeloop %]
             [% FOREACH categoryloo IN typeloo.categoryloop %]
             [% END %]
        [% END %]
        </select>
+       <span class="required">Required</span>
     </li>
         [% UNLESS nosort1 %]
     <li>