Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl
authorJulian Maurice <julian.maurice@biblibre.com>
Fri, 3 Feb 2023 10:58:51 +0000 (11:58 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 24 Feb 2023 19:43:57 +0000 (16:43 -0300)
Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
cataloguing/value_builder/unimarc_field_105.pl

index f0ff7f2..35acbc0 100755 (executable)
@@ -33,9 +33,10 @@ sub plugin_javascript {
     my ($dbh,$record,$tagslib,$field_number) = @_;
     my $res="
     <script>
-        function Clic$field_number() {
-                defaultvalue=document.getElementById(\"$field_number\").value;
-                window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_105.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_105\",'width=1200,height=400,toolbar=false,scrollbars=yes');
+        function Clic$field_number(ev) {
+                ev.preventDefault();
+                defaultvalue=document.getElementById(ev.data.id).value;
+                window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_105.pl&index=\" + ev.data.id + \"&result=\"+defaultvalue,\"unimarc_field_105\",'width=1200,height=400,toolbar=false,scrollbars=yes');
 
         }
     </script>