Bug 28003: Invoice adjustments using inactive budgets do not indicate that status
authorNick Clemens <nick@bywatersolutions.com>
Fri, 19 Mar 2021 15:02:12 +0000 (15:02 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 1 Apr 2021 16:04:49 +0000 (18:04 +0200)
This patch affects the display of existing invoice adjustments to indicate when using an inactive budget

To recreate
1 - In acquisitions go to a vendor
2 - Click 'Receive'
3 - Create an invoice
4 - Finish receiving
5 - Go to Admin->budgets
6 - Duplicate your current budget
7 - Mark the original budget inactive
8 - View the invoice you created
9 - No indication the budget is inactive
10 - Apply patch
11 - Reload the page
12 - The fund shows '(inactive)'
13 - The dropdown to edit the funds also indicates which funds are inactive

Note that adding new adjustments does show only the active budget unless you request to see inactive.

Signed-off-by: Amit Gupta <amitddng135@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt

index 6638449..52b586b 100644 (file)
                                                   [% ELSE %]
                                                       <option value="[% budget.b_id | html %]">
                                                   [% END %]
-                                                  [% budget.b_txt | html %]
+                                                  [% IF budget.b_active %]
+                                                      [% budget.b_txt | html %]
+                                                  [% ELSE %]
+                                                      [% budget.b_txt | html %] (inactive)
+                                                  [% END %]
                                                   </option>
                                               [% END %]
                                           </select>