Bug 26515: Don't need to call safe_to_delete
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 15 Oct 2020 13:17:46 +0000 (15:17 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 15 Oct 2020 13:17:46 +0000 (15:17 +0200)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Acquisition/Order.pm

index c913a29..07dea68 100644 (file)
@@ -127,15 +127,12 @@ sub cancel {
     # Delete the related items
     my $items = $self->items;
     while ( my $item = $items->next ) {
-        my $safe_to_delete = $item->safe_to_delete;
-        if ( $safe_to_delete eq '1' ) {
-            $item->safe_delete;
-        }
-        else {
+        my $deleted = $item->safe_delete;
+        unless ( ref($deleted) eq 'Koha::Item' ) {
             $self->add_message(
                 {
                     message => 'error_delitem',
-                    payload => { item => $item, reason => $safe_to_delete }
+                    payload => { item => $item, reason => $deleted }
                 }
             );
         }