Bug 29897: Rename get_marc_authors with get_marc_contributors

get_marc_authors actually return authors from 700..712, not the first
author from 200

Sponsored-by: Orex Digital
Signed-off-by: Orex Digital <info@orex.es>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
index 5a1be3c..56edb03 100644 (file)
--- a/Koha/Biblio.pm
+++ b/Koha/Biblio.pm
@@ -1001,16 +1001,16 @@ sub get_marc_notes {
     return \@marcnotes;
 }
 
-=head3 get_marc_authors
+=head3 get_marc_contributors
 
-    my $authors = $biblio->get_marc_authors;
+    my $contributors = $biblio->get_marc_contributors;
 
-Get all authors from the MARC record and returns them in an array.
-The authors are stored in different fields depending on MARC flavour
+Get all contributors (but first author) from the MARC record and returns them in an array.
+They are stored in different fields depending on MARC flavour
 
 =cut
 
-sub get_marc_authors {
+sub get_marc_contributors {
     my ( $self, $params ) = @_;
 
     my ( $mintag, $maxtag, $fields_filter );

diff --git a/basket/basket.pl b/basket/basket.pl
index 6f93e5a..fc69f51 100755 (executable)
--- a/basket/basket.pl
+++ b/basket/basket.pl
@@ -68,7 +68,7 @@ foreach my $biblionumber ( @bibs ) {
     my $dat              = $biblio->unblessed;
     my $record           = $biblio->metadata->record;
     my $marcnotesarray   = $biblio->get_marc_notes;
-    my $marcauthorsarray = $biblio->get_marc_authors;
+    my $marcauthorsarray = $biblio->get_marc_contributors;
     my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
     my $marcseriesarray  = GetMarcSeries  ($record,$marcflavour);
     my $marcurlsarray    = GetMarcUrls    ($record,$marcflavour);

diff --git a/basket/sendbasket.pl b/basket/sendbasket.pl
index c5bf982..04882db 100755 (executable)
--- a/basket/sendbasket.pl
+++ b/basket/sendbasket.pl
@@ -73,7 +73,7 @@ if ( $email_add ) {
         my $biblio           = Koha::Biblios->find( $biblionumber ) or next;
         my $dat              = $biblio->unblessed;
         my $record           = $biblio->metadata->record({ embed_items => 1 });
-        my $marcauthorsarray = $biblio->get_marc_authors;
+        my $marcauthorsarray = $biblio->get_marc_contributors;
         my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
 
         my @items = GetItemsInfo( $biblionumber );

diff --git a/opac/opac-basket.pl b/opac/opac-basket.pl
index bf3e6f4..f2eefd0 100755 (executable)
--- a/opac/opac-basket.pl
+++ b/opac/opac-basket.pl
@@ -84,7 +84,7 @@ foreach my $biblionumber ( @bibs ) {
     $record_processor->process($record);
     next unless $record;
     my $marcnotesarray   = $biblio->get_marc_notes({ opac => 1 });
-    my $marcauthorsarray = $biblio->get_marc_authors;
+    my $marcauthorsarray = $biblio->get_marc_contributors;
     my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
     my $marcseriesarray  = GetMarcSeries  ($record,$marcflavour);
     my $marcurlsarray    = GetMarcUrls    ($record,$marcflavour);

diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl
index fcc49e0..9448f21 100755 (executable)
--- a/opac/opac-sendbasket.pl
+++ b/opac/opac-sendbasket.pl
@@ -85,7 +85,7 @@ if ( $email_add ) {
                 patron      => $patron,
             }
         );
-        my $marcauthorsarray = $biblio->get_marc_authors;
+        my $marcauthorsarray = $biblio->get_marc_contributors;
         my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
 
         my @items = GetItemsInfo( $biblionumber );

diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl
index 9154281..817c106 100755 (executable)
--- a/opac/opac-sendshelf.pl
+++ b/opac/opac-sendshelf.pl
@@ -94,7 +94,7 @@ if ( $shelf and $shelf->can_be_viewed( $borrowernumber ) ) {
         next unless $record;
         my $fw               = GetFrameworkCode($biblionumber);
 
-        my $marcauthorsarray = $biblio->get_marc_authors;
+        my $marcauthorsarray = $biblio->get_marc_contributors;
         my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
 
         my @items = GetItemsInfo( $biblionumber );

diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t
index df9dffe..f1633de 100755 (executable)
--- a/t/db_dependent/Koha/Biblio.t
+++ b/t/db_dependent/Koha/Biblio.t
@@ -881,7 +881,7 @@ subtest 'current_checkouts() and old_checkouts() tests' => sub {
     $schema->storage->txn_rollback;
 };
 
-subtest 'get_marc_authors() tests' => sub {
+subtest 'get_marc_contributors() tests' => sub {
 
     plan tests => 1;
 
@@ -904,7 +904,7 @@ subtest 'get_marc_authors() tests' => sub {
     C4::Biblio::ModBiblio( $record, $biblio->biblionumber );
     $biblio = Koha::Biblios->find( $biblio->biblionumber );
 
-    is( 4, @{$biblio->get_marc_authors}, 'get_marc_authors retrieves correct number of author subfields' );
+    is( 4, @{$biblio->get_marc_contributors}, 'get_marc_contributors retrieves correct number of author subfields' );
     $schema->storage->txn_rollback;
 };
 

diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl
index 0bcb43c..e870928 100755 (executable)
--- a/virtualshelves/sendshelf.pl
+++ b/virtualshelves/sendshelf.pl
@@ -80,7 +80,7 @@ if ($to_address) {
         my $biblio           = Koha::Biblios->find( $biblionumber ) or next;
         my $dat              = $biblio->unblessed;
         my $record           = $biblio->metadata->record({ embed_items => 1 });
-        my $marcauthorsarray = $biblio->get_marc_authors;
+        my $marcauthorsarray = $biblio->get_marc_contributors;
         my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
 
         my @items = GetItemsInfo($biblionumber);