Bug 32222: Fix capitalization in various "id is invalid"

ID is an abbreviation and should be written with capitals.

See: https://www.oxfordlearnersdictionaries.com/definition/english/identification

This fixes all occurences of "id is invalid" to read "ID is invalid"

To test:
* As some are hard to trigger warnings, the best way here is to review the patch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

diff --git a/C4/Creators/Batch.pm b/C4/Creators/Batch.pm
index e81f6d6..41a7c0c 100644 (file)
--- a/C4/Creators/Batch.pm
+++ b/C4/Creators/Batch.pm
@@ -180,7 +180,7 @@ sub delete {
         @query_params = ($opts{'batch_id'}, $opts{'branch_code'});
     }
     if ($query_params[0] eq '') {   # If there is no template id then we cannot delete it
-        warn sprintf('%s : Cannot delete batch as the batch id is invalid or non-existent.', $call_type);
+        warn sprintf('%s : Cannot delete batch as the batch ID is invalid or non-existent.', $call_type);
         return -1;
     }
     my $query = "DELETE FROM creator_batches WHERE batch_id = ? AND branch_code =?";

diff --git a/C4/Creators/Layout.pm b/C4/Creators/Layout.pm
index a321636..4ac7908 100644 (file)
--- a/C4/Creators/Layout.pm
+++ b/C4/Creators/Layout.pm
@@ -126,7 +126,7 @@ sub delete {
         push @params, $opts{'layout_id'}, $opts{'creator'};
     }
     if (scalar(@params) < 2) {   # If there is no layout id or creator type then we cannot delete it
-        warn sprintf('%s : Cannot delete layout as the profile id is invalid or non-existent.', $call_type) if !$params[0];
+        warn sprintf('%s : Cannot delete layout as the profile ID is invalid or non-existent.', $call_type) if !$params[0];
         warn sprintf('%s : Cannot delete layout as the creator type is invalid or non-existent.', $call_type) if !$params[1];
         return -1;
     }

diff --git a/C4/Creators/Profile.pm b/C4/Creators/Profile.pm
index b9759bd..d9b84ca 100644 (file)
--- a/C4/Creators/Profile.pm
+++ b/C4/Creators/Profile.pm
@@ -106,7 +106,7 @@ sub delete {
         push @params, $opts{'profile_id'}, $opts{'creator'};
     }
     if (scalar(@params) < 2) {   # If there is no profile id or creator type then we cannot delete it
-        warn sprintf('%s : Cannot delete profile as the profile id is invalid or non-existent.', $call_type) if !$params[0];
+        warn sprintf('%s : Cannot delete profile as the profile ID is invalid or non-existent.', $call_type) if !$params[0];
         warn sprintf('%s : Cannot delete profile as the creator type is invalid or non-existent.', $call_type) if !$params[1];
         return -1;
     }

diff --git a/C4/Creators/Template.pm b/C4/Creators/Template.pm
index 1636c16..2699886 100644 (file)
--- a/C4/Creators/Template.pm
+++ b/C4/Creators/Template.pm
@@ -146,7 +146,7 @@ sub delete {
         push @query_params, $opts{'template_id'}, $opts{'creator'};
     }
     if (scalar(@query_params) < 2) {   # If there is no template id or creator type then we cannot delete it
-        warn sprintf('%s : Cannot delete template as the template id is invalid or non-existent.', $call_type) if !$query_params[0];
+        warn sprintf('%s : Cannot delete template as the template ID is invalid or non-existent.', $call_type) if !$query_params[0];
         warn sprintf('%s : Cannot delete template as the creator type is invalid or non-existent.', $call_type) if !$query_params[1];
         return -1;
     }

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt
index 4ca4767..ad1bd87 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt
@@ -70,7 +70,7 @@
     <div class="dialog [% m.type | html %]" id="identity_provider_domain_action_result_dialog">
         [% SWITCH m.code %]
         [% CASE 'error_on_update' %]
-            <span>An error occurred trying to open the identity provider domain for editing. The passed id is invalid.</span>
+            <span>An error occurred trying to open the identity provider domain for editing. The passed ID is invalid.</span>
         [% CASE 'error_on_insert' %]
             <span>An error occurred when adding a new identity provider domain.</span>
         [% CASE 'success_on_update' %]

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt
index 7deee34..6dcb3b0 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt
@@ -66,7 +66,7 @@
     <div class="dialog [% m.type | html %]" id="identity_provider_action_result_dialog">
         [% SWITCH m.code %]
         [% CASE 'error_on_update' %]
-            <span>An error occurred trying to open the identity provider for editing. The passed id is invalid.</span>
+            <span>An error occurred trying to open the identity provider for editing. The passed ID is invalid.</span>
         [% CASE 'error_on_insert' %]
             <span>An error occurred when adding a new identity provider.</span>
         [% CASE 'success_on_update' %]

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt
index c225fc9..5c5e6f5 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt
@@ -166,7 +166,7 @@
 
     <h1>Patron restrictions</h1>
     [% IF searchfield %]
-        You Searched for [% searchfield | html %]</span>
+        You searched for [% searchfield | html %]</span>
     [% END %]
     [% IF restrictions %]
         <div class="page-section">

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
index c48d1bd..701e687 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
@@ -64,7 +64,7 @@
     <div class="dialog [% m.type | html %]" id="smtp_action_result_dialog">
         [% SWITCH m.code %]
         [% CASE 'error_on_update' %]
-            <span>An error occurred trying to open the server for editing. The passed id is invalid.</span>
+            <span>An error occurred trying to open the server for editing. The passed ID is invalid.</span>
         [% CASE 'error_on_insert' %]
             <span>An error occurred when adding the server. The library already has an SMTP server set.</span>
         [% CASE 'success_on_update' %]