Bug 12666 - Fix poor HTML from circ/offline.tt
authorMark Tompsett <mtompset@hotmail.com>
Mon, 28 Jul 2014 21:36:01 +0000 (17:36 -0400)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Fri, 15 Aug 2014 17:59:17 +0000 (14:59 -0300)
In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt
- Cleaned up the HTML's missing </div>'s
- Corrected the autobuffer attribute to the newer preload one
- Added &nbsp; into empty title, since it will get replaced

TEST PLAN
---------
1) Run the circ/offline.pl page source through an HTML validator
   -- should get a few warnings
2) Apply patch
3) Recheck page source (confirm your page isn't cached!)
   -- should be clean

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Improves HTML validity, no regressions found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt

index 0a922a5..b8a679d 100644 (file)
@@ -586,8 +586,8 @@ $(document).ready(function () {
 
     <div id="bd">
         <div id="yui-main">
-            <audio id="alert_sound" src="[% interface %]/prog/sound/critical.ogg" autobuffer="autobuffer"></audio>
-            <audio id="success_sound" src="[% interface %]/prog/sound/beep.ogg" autobuffer="autobuffer"></audio>
+            <audio id="alert_sound" src="[% interface %]/prog/sound/critical.ogg" preload="auto"></audio>
+            <audio id="success_sound" src="[% interface %]/prog/sound/beep.ogg" preload="auto"></audio>
 
             <div id="alerts" class="yui-b">
             </div>
@@ -761,7 +761,7 @@ $(document).ready(function () {
     </div>
 
     <div class="yui-b offline-circulation" style="display: none;">
-        <div class="patroninfo"><h5 class="patron-title"></h5>
+        <div class="patroninfo"><h5 class="patron-title">&nbsp;</h5>
             <ul>
                 <li id="patron-address-1"></li>
                 <li id="patron-address-2"></li>
@@ -772,5 +772,7 @@ $(document).ready(function () {
                 <li id="patron-library"></li>
             </ul>
         </div>
+    </div>
+</div>
 
 [% INCLUDE 'intranet-bottom.inc' %]