renewbook is used by renewscript.pl
authorrangi <rangi>
Wed, 30 Apr 2003 22:55:54 +0000 (22:55 +0000)
committerrangi <rangi>
Wed, 30 Apr 2003 22:55:54 +0000 (22:55 +0000)
Making sure characters are escaped in the database insert

C4/Circulation/Renewals2.pm

index be3393c..702d50b 100755 (executable)
@@ -224,9 +224,10 @@ sub renewbook {
     my $account="Insert into accountlines
     (borrowernumber,accountno,date,amount,description,accounttype,amountoutstanding,itemnumber)
     values
-    ('$bornum','$accountno',now(),$charge,'Renewal of Rental Item $item->{'title'} $item->{'barcode'}','Rent',$charge,'$itemno')";
+    (?,?,now(),?,?,?,?,?)";
     $sth=$dbh->prepare($account);
-    $sth->execute;
+    $sth->execute($bornum,$accountno,$charge,"Renewal of Rental Item $item->{'title'} $item->{'barcode'}",
+    'Rent',$charge,$itemno)";
     $sth->finish;
 #     print $account;
   }