my $loanlength = $sth->fetchrow_hashref;
return $loanlength
- if defined($loanlength) && $loanlength->{issuelength};
+ if defined($loanlength) && defined $loanlength->{issuelength};
$sth->execute( $borrowertype, '*', $branchcode );
$loanlength = $sth->fetchrow_hashref;
return $loanlength
- if defined($loanlength) && $loanlength->{issuelength};
+ if defined($loanlength) && defined $loanlength->{issuelength};
$sth->execute( '*', $itemtype, $branchcode );
$loanlength = $sth->fetchrow_hashref;
return $loanlength
- if defined($loanlength) && $loanlength->{issuelength};
+ if defined($loanlength) && defined $loanlength->{issuelength};
$sth->execute( '*', '*', $branchcode );
$loanlength = $sth->fetchrow_hashref;
return $loanlength
- if defined($loanlength) && $loanlength->{issuelength};
+ if defined($loanlength) && defined $loanlength->{issuelength};
$sth->execute( $borrowertype, $itemtype, '*' );
$loanlength = $sth->fetchrow_hashref;
return $loanlength
- if defined($loanlength) && $loanlength->{issuelength};
+ if defined($loanlength) && defined $loanlength->{issuelength};
$sth->execute( $borrowertype, '*', '*' );
$loanlength = $sth->fetchrow_hashref;
return $loanlength
- if defined($loanlength) && $loanlength->{issuelength};
+ if defined($loanlength) && defined $loanlength->{issuelength};
$sth->execute( '*', $itemtype, '*' );
$loanlength = $sth->fetchrow_hashref;
return $loanlength
- if defined($loanlength) && $loanlength->{issuelength};
+ if defined($loanlength) && defined $loanlength->{issuelength};
$sth->execute( '*', '*', '*' );
$loanlength = $sth->fetchrow_hashref;
return $loanlength
- if defined($loanlength) && $loanlength->{issuelength};
+ if defined($loanlength) && defined $loanlength->{issuelength};
- # if no rule is set => 21 days (hardcoded)
+ # if no rule is set => 0 day (hardcoded)
return {
- issuelength => 21,
- renewalperiod => 21,
+ issuelength => 0,
+ renewalperiod => 0,
lengthunit => 'days',
};
#Begin Tests
+my $default = {
+ issuelength => 0,
+ renewalperiod => 0,
+ lengthunit => 'days'
+};
+
#Test GetIssuingRule
my $sampleissuingrule1 = {
reservecharge => '0.000000',
{ issuelength => 5, lengthunit => 'days', renewalperiod => 5 },
"GetLoanLength"
);
+
is_deeply(
C4::Circulation::GetLoanLength(),
- {
- issuelength => 21,
- renewalperiod => 21,
- lengthunit => 'days',
- },
+ $default,
"Without parameters, GetLoanLength returns hardcoded values"
);
is_deeply(
C4::Circulation::GetLoanLength( -1, -1 ),
- {
- issuelength => 21,
- renewalperiod => 21,
- lengthunit => 'days',
- },
+ $default,
"With wrong parameters, GetLoanLength returns hardcoded values"
);
is_deeply(
C4::Circulation::GetLoanLength( $samplecat->{categorycode} ),
- {
- issuelength => 21,
- renewalperiod => 21,
- lengthunit => 'days',
- },
+ $default,
"With only one parameter, GetLoanLength returns hardcoded values"
); #NOTE : is that really what is expected?
is_deeply(
C4::Circulation::GetLoanLength( $samplecat->{categorycode}, 'BOOK' ),
- {
- issuelength => 21,
- renewalperiod => 21,
- lengthunit => 'days',
- },
+ $default,
"With only two parameters, GetLoanLength returns hardcoded values"
); #NOTE : is that really what is expected?
is_deeply(