Bug 17292: Follow up - tweak to make it pass cleaner
authorMark Tompsett <mtompset@hotmail.com>
Mon, 19 Sep 2016 00:47:33 +0000 (20:47 -0400)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Mon, 10 Oct 2016 10:20:56 +0000 (10:20 +0000)
remove a 'my'
next if not defined subscriptions.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
installer/data/mysql/updatedatabase.pl

index f638fa7..cda1b02 100755 (executable)
@@ -11477,9 +11477,10 @@ if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
     my $sth3 = $dbh->prepare("UPDATE serials SET serialseq_x = ?, serialseq_y = ?, serialseq_z = ? WHERE serialid = ?");
 
     foreach my $subscription ( $sth->fetchrow_hashref() ) {
+        next if !defined($subscription);
         my $number_pattern = $subscription->numberpattern();
         $sth2->execute( $subscription->{numberpattern} );
-        my $number_pattern = $sth2->fetchrow_hashref();
+        $number_pattern = $sth2->fetchrow_hashref();
 
         my $numbering_method = $number_pattern->{numberingmethod};
         # Get all the data between the enumeration values, we need