Bug 18484 - opac-advsearch.tt missing closing div tag for .container-fluid
authorOwen Leonard <oleonard@myacpl.org>
Mon, 24 Apr 2017 14:21:00 +0000 (14:21 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 28 Apr 2017 13:02:46 +0000 (09:02 -0400)
This patch corrects HTML validation errors by adding back a missing
</div> which was removed accidentally by Bug 9043 (2014!).

This patch also removes "border" attributes from <img> tags because the
attribute is obsolete.

To test, apply the patch and test the validity of the OPAC's advanced
search page. The only error should be one about 'Bad value
"api-server,"' which isn't really resolvable.

Signed-off-by: Barton Chittenden <barton@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt

index 94963c4..d1d9b25 100644 (file)
                                                     <label for="[% itemtypeloo.ccl FILTER remove(',') %]-[% itemtypeloo.number %]">
                                                         [% UNLESS ( noItemTypeImages ) %]
                                                             [% IF ( itemtypeloo.imageurl ) %]
-                                                                <img border="0" src="[% itemtypeloo.imageurl %]" alt="[% itemtypeloo.description %]" />
+                                                                <img src="[% itemtypeloo.imageurl %]" alt="[% itemtypeloo.description %]" />
                                                             [% END %]
                                                             &nbsp;
                                                         [% END %]
                 [% END # / IF expanded_options %]
             </div> <!-- / .row-fluid -->
 
-        [% IF ( OpacAdvSearchMoreOptions and OpacAdvSearchMoreOptions.size > 0 and expanded_options ) or
-              ( OpacAdvSearchOptions     and OpacAdvSearchOptions.size > 0     and not expanded_options ) %]
-            <div class="row-fluid">
-                <div class="span12">
-                    <div class="text-center">
-                        <!-- SEARCH BUTTONS -->
-                        [% PROCESS searchbuttons %]
-                        <!-- /SEARCH BUTTONS -->
-                    </div>
-                </div> <!-- / .span12 -->
-            </div> <!-- / .row-fluid -->
-        [% END %]
+            [% IF ( OpacAdvSearchMoreOptions and OpacAdvSearchMoreOptions.size > 0 and expanded_options ) or
+                  ( OpacAdvSearchOptions     and OpacAdvSearchOptions.size > 0     and not expanded_options ) %]
+                <div class="row-fluid">
+                    <div class="span12">
+                        <div class="text-center">
+                            <!-- SEARCH BUTTONS -->
+                            [% PROCESS searchbuttons %]
+                            <!-- /SEARCH BUTTONS -->
+                        </div>
+                    </div> <!-- / .span12 -->
+                </div> <!-- / .row-fluid -->
+            [% END %]
+        </div> <!-- / .container-fluid -->
    </div> <!-- / .main -->
 </form>