Changing innerjoin to left join for mysql5

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

diff --git a/C4/Circulation/Fines.pm b/C4/Circulation/Fines.pm
index 1907c3d..aea6b80 100644 (file)
--- a/C4/Circulation/Fines.pm
+++ b/C4/Circulation/Fines.pm
@@ -562,11 +562,11 @@ sub GetIssuingRules {
    my ($itemnumber,$categorycode)=@_;
    my $dbh   = C4::Context->dbh();    
    my $query=qq|SELECT * 
-        FROM items,biblioitems,itemtypes,issuingrules
+        FROM items
+        LEFT JOIN biblioitems ON items.biblioitemnumber=biblioitems.biblioitemnumber
+        LEFT JOIN itemtypes ON  biblioitems.itemtype=itemtypes.itemtype
+        LEFT JOIN issuingrules ON issuingrules.itemtype=itemtypes.itemtype
         WHERE items.itemnumber=?
-        AND items.biblioitemnumber=biblioitems.biblioitemnumber
-        AND biblioitems.itemtype=itemtypes.itemtype
-        AND issuingrules.itemtype=itemtypes.itemtype
         AND issuingrules.categorycode=?
         AND  (items.itemlost <> 1
         OR items.itemlost is NULL)|;