Bug 7817 - Items Permanent location (shelving location) is set to NULL when item...
authorOlli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
Wed, 18 Jun 2014 15:31:13 +0000 (18:31 +0300)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 8 Sep 2014 14:42:20 +0000 (11:42 -0300)
A quick fix to prevent more damages.
No perceived side-effects so far.

Signed-off-by: David Cook <dcook@prosentient.com.au>
This is actually a perfectly good fix for this issue. I've changed
the explanatory comment to explain why.

Another option would be to remove the 'exists' check in the sub
_do_column_fixes_for_mod(), but this is just as functional.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Detailed comment on Bugzilla.
Adding a small follow-up.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Items.pm

index 70af5ef..1ce5436 100644 (file)
@@ -459,7 +459,7 @@ my %default_values_for_mod_from_marc = (
     itemnotes            => undef, 
     itype                => undef, 
     location             => undef, 
-    permanent_location   => undef,
+#    permanent_location   => undef, # "undef" counts as "exists" which disrupts proper handling of location and permanent_location in _do_column_fixes_for_mod()
     materials            => undef, 
     notforloan           => 0,
     paidfor              => undef,