2 BUGFIX (1 being unimarc specific) : change in plugin handling

before this commit, the main (usually $a) entry could not be entered by the librarian.
With the new BiblioAddAuthority feature, it's a bad idea : the librarian will
be able to enter a value manually, and the authority will be automatically created on the fly
Thus the small change in addbiblio.pl

This commit also fixes a bug in plugin 4XX (which is unimarc specific) :
"Empty" option did not work properly + API convention fix (biblionumber instead of bibnum)

Signed-off-by: Chris Cormack <crc@liblime.com>

diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
index 39c803c..4616f61 100755 (executable)
--- a/cataloguing/addbiblio.pl
+++ b/cataloguing/addbiblio.pl
@@ -316,15 +316,15 @@ sub create_input {
     }
     elsif ( $tagslib->{$tag}->{$subfield}->{authtypecode} ) {
         $subfield_data{marc_value} =
-               "<input type=\"text\"
-                        id=\"".$subfield_data{id}."\"
-                        name=\"".$subfield_data{id}."\"
-                       value=\"$value\"
-                       class=\"input_marceditor\"
-                        tabindex=\"1\"                     
-                       disabled=\"disabled\" readonly=\"readonly\" \/>
-                       <span class=\"buttonDot\"
-                               onclick=\"Dopop('/cgi-bin/koha/authorities/auth_finder.pl?authtypecode=".$tagslib->{$tag}->{$subfield}->{authtypecode}."&index=$subfield_data{id}','$subfield_data{id}')\">...</span>
+            "<input type=\"text\"
+                    id=\"".$subfield_data{id}."\"
+                    name=\"".$subfield_data{id}."\"
+                    value=\"$value\"
+                    class=\"input_marceditor\"
+                    tabindex=\"1\"
+                    \/>
+                    <span class=\"buttonDot\"
+                        onclick=\"Dopop('/cgi-bin/koha/authorities/auth_finder.pl?authtypecode=".$tagslib->{$tag}->{$subfield}->{authtypecode}."&index=$subfield_data{id}','$subfield_data{id}')\">...</span>
                ";
     # it's a plugin field
     }

diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl
index cb40921..75b7104 100755 (executable)
--- a/cataloguing/value_builder/unimarc_field_4XX.pl
+++ b/cataloguing/value_builder/unimarc_field_4XX.pl
@@ -83,7 +83,7 @@ sub plugin {
     my $searchdesc;
 
     if ( $op eq "fillinput" ) {
-        my $bibnum = $query->param('bibnum');
+        my $biblionumber = $query->param('biblionumber');
         my $index  = $query->param('index');
         my $marcrecord;
 
@@ -101,9 +101,9 @@ sub plugin {
         );
 
         #get marc record
-        $marcrecord = GetMarcBiblio($bibnum);
+        $marcrecord = GetMarcBiblio($biblionumber);
 
-        my $subfield_value_9 = $bibnum;
+        my $subfield_value_9 = $biblionumber;
         my $subfield_value_0;
         $subfield_value_0 = $marcrecord->field('001')->data
           if $marcrecord->field('001');
@@ -293,21 +293,21 @@ sub plugin {
         $template->param(
             fillinput        => 1,
             index            => $query->param('index') . "",
-            biblionumber     => $bibnum ? $bibnum : "",
-            subfield_value_9 => $subfield_value_9,
-            subfield_value_0 => $subfield_value_0,
-            subfield_value_a => $subfield_value_a,
-            subfield_value_c => $subfield_value_c,
-            subfield_value_d => $subfield_value_d,
-            subfield_value_e => $subfield_value_e,
-            subfield_value_h => $subfield_value_h,
-            subfield_value_i => $subfield_value_i,
-            subfield_value_p => $subfield_value_p,
-            subfield_value_t => $subfield_value_t,
-            subfield_value_u => $subfield_value_u,
-            subfield_value_v => $subfield_value_v,
-            subfield_value_x => $subfield_value_x,
-            subfield_value_y => $subfield_value_y,
+            biblionumber     => $biblionumber ? $biblionumber : "",
+            subfield_value_9 => "$subfield_value_9",
+            subfield_value_0 => "$subfield_value_0",
+            subfield_value_a => "$subfield_value_a",
+            subfield_value_c => "$subfield_value_c",
+            subfield_value_d => "$subfield_value_d",
+            subfield_value_e => "$subfield_value_e",
+            subfield_value_h => "$subfield_value_h",
+            subfield_value_i => "$subfield_value_i",
+            subfield_value_p => "$subfield_value_p",
+            subfield_value_t => "$subfield_value_t",
+            subfield_value_u => "$subfield_value_u",
+            subfield_value_v => "$subfield_value_v",
+            subfield_value_x => "$subfield_value_x",
+            subfield_value_y => "$subfield_value_y",
         );
 ###############################################################
     }

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tmpl
index effe7ad..eac7ff7 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tmpl
@@ -161,9 +161,9 @@
                                        </td>
                                        <td>
                       <!--TMPL_IF Name="biblionumber"-->
-                                               <a href="javascript:jumpfull('/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=<!--TMPL_VAR Name="index"-->&bibnum=<!--TMPL_VAR Name="biblionumber"-->&type=intranet&op=fillinput')">Choose</a>
+                                               <a href="javascript:jumpfull('/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=<!--TMPL_VAR Name="index"-->&biblionumber=<!--TMPL_VAR Name="biblionumber"-->&type=intranet&op=fillinput')">Choose</a>
                       <!--TMPL_ELSE-->
-                                               <a href="javascript:jumpfull('/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=<!--TMPL_VAR Name="index"-->&bibnum=<!--TMPL_VAR Name="biblionumber"-->&type=intranet&op=fillinput')">Clear Field</a>
+                                               <a href="javascript:jumpfull('/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=<!--TMPL_VAR Name="index"-->&type=intranet&op=fillinput')">Clear Field</a>
                       <!--/TMPL_IF-->
                                        </td>
                                </tr>