Bug 17095: (bug 16849 follow-up) Fix regression if patron does not exist
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 9 Aug 2016 19:08:54 +0000 (20:08 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Thu, 18 Aug 2016 16:04:17 +0000 (16:04 +0000)
Bug 16082, 'Display a friendly "patron does not exist" message if that's the
case - circulation.pl' changed the behavior of the checkout page so that if
you hit that page with a borrowernumber which doesn't exist a nice message will
tell you so.

Now when you do that you get an error message:
  Can't call method "is_debarred" on an undefined value at /circ/circulation.pl line 300.

Test plan:
confirm that the friendly message is back :)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
circ/circulation.pl

index eddd996..940e902 100755 (executable)
@@ -297,7 +297,8 @@ if ($borrowernumber) {
         finetotal    => $fines
     );
 
-    if ( Koha::Patrons->find( $borrowernumber )->is_debarred ) {
+    my $patron = Koha::Patrons->find( $borrowernumber );
+    if ( $patron and $patron->is_debarred ) {
         $template->param(
             'userdebarred'    => $borrower->{debarred},
             'debarredcomment' => $borrower->{debarredcomment},