Bug 19974: (QA follow-up) Do not use bar separator in atomic update
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 20 Apr 2018 06:21:33 +0000 (08:21 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 20 Apr 2018 14:57:31 +0000 (11:57 -0300)
The multiple select saves the selected values with a comma.
Furthermore, preferences.pl also splits on a comma. In other words, the
upgrade will not work with the bar character. All options will be
deselected.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
installer/data/mysql/atomicupdate/bug_19974.perl

index 78ff577..602fa89 100644 (file)
@@ -8,7 +8,7 @@ if( CheckVersion( $DBversion ) ) {
             UPDATE systempreferences
             SET type="multiple",
                 options="batchmod|moredetail|cronjob|additem",
-                value="batchmod|moredetail|cronjob|additem"
+                value="batchmod,moredetail,cronjob,additem"
             WHERE variable="MarkLostItemsAsReturned"
         });
     } else {